0f0a24e298
Summary:
Add an option for arena block size, default value 4096 bytes. Arena will allocate blocks with such size.
I am not sure about passing parameter to skiplist in the new virtualized framework, though I talked to Jim a bit. So add Jim as reviewer.
Test Plan:
new unit test, I am running db_test.
For passing paramter from configured option to Arena, I tried tests like:
TEST(DBTest, Arena_Option) {
std::string dbname = test::TmpDir() + "/db_arena_option_test";
DestroyDB(dbname, Options());
DB* db = nullptr;
Options opts;
opts.create_if_missing = true;
opts.arena_block_size = 1000000; // tested 99, 999999
Status s = DB::Open(opts, dbname, &db);
db->Put(WriteOptions(), "a", "123");
}
and printed some debug info. The results look good. Any suggestion for such a unit-test?
Reviewers: haobo, dhruba, emayanke, jpaton
Reviewed By: dhruba
CC: leveldb, zshao
Differential Revision: https://reviews.facebook.net/D11799
84 lines
2.3 KiB
C++
84 lines
2.3 KiB
C++
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
|
|
// ArenaImpl is an implementation of Arena class. For a request of small size,
|
|
// it allocates a block with pre-defined block size. For a request of big
|
|
// size, it uses malloc to directly get the requested size.
|
|
|
|
#ifndef STORAGE_LEVELDB_UTIL_ARENA_IMPL_H_
|
|
#define STORAGE_LEVELDB_UTIL_ARENA_IMPL_H_
|
|
|
|
#include <cstddef>
|
|
#include <vector>
|
|
#include <assert.h>
|
|
#include <stdint.h>
|
|
#include "leveldb/arena.h"
|
|
|
|
namespace leveldb {
|
|
|
|
class ArenaImpl : public Arena {
|
|
public:
|
|
explicit ArenaImpl(size_t block_size = kMinBlockSize);
|
|
virtual ~ArenaImpl();
|
|
|
|
virtual char* Allocate(size_t bytes);
|
|
|
|
virtual char* AllocateAligned(size_t bytes);
|
|
|
|
// Returns an estimate of the total memory usage of data allocated
|
|
// by the arena (including space allocated but not yet used for user
|
|
// allocations).
|
|
//
|
|
// TODO: Do we need to exclude space allocated but not used?
|
|
virtual const size_t ApproximateMemoryUsage() {
|
|
return blocks_memory_ + blocks_.capacity() * sizeof(char*);
|
|
}
|
|
|
|
virtual const size_t MemoryAllocatedBytes() {
|
|
return blocks_memory_;
|
|
}
|
|
|
|
private:
|
|
char* AllocateFallback(size_t bytes);
|
|
char* AllocateNewBlock(size_t block_bytes);
|
|
|
|
static const size_t kMinBlockSize = 4096;
|
|
static const size_t kMaxBlockSize = 2 << 30;
|
|
|
|
// Number of bytes allocated in one block
|
|
size_t block_size_;
|
|
|
|
// Allocation state
|
|
char* alloc_ptr_;
|
|
size_t alloc_bytes_remaining_;
|
|
|
|
// Array of new[] allocated memory blocks
|
|
std::vector<char*> blocks_;
|
|
|
|
// Bytes of memory in blocks allocated so far
|
|
size_t blocks_memory_;
|
|
|
|
// No copying allowed
|
|
ArenaImpl(const ArenaImpl&);
|
|
void operator=(const ArenaImpl&);
|
|
};
|
|
|
|
inline char* ArenaImpl::Allocate(size_t bytes) {
|
|
// The semantics of what to return are a bit messy if we allow
|
|
// 0-byte allocations, so we disallow them here (we don't need
|
|
// them for our internal use).
|
|
assert(bytes > 0);
|
|
if (bytes <= alloc_bytes_remaining_) {
|
|
char* result = alloc_ptr_;
|
|
alloc_ptr_ += bytes;
|
|
alloc_bytes_remaining_ -= bytes;
|
|
return result;
|
|
}
|
|
return AllocateFallback(bytes);
|
|
}
|
|
|
|
} // namespace leveldb
|
|
|
|
#endif // STORAGE_LEVELDB_UTIL_ARENA_IMPL_H_
|