andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
rocksdb/table
History
Zhongyi Xie 9196e80b15 Reduce heavy hitter for Get operation 
Summary:
This PR addresses the following heavy hitters in `Get` operation by moving calls to `StatisticsImpl::recordTick` from `BlockBasedTable` to `Version::Get`

- rocksdb.block.cache.bytes.write
- rocksdb.block.cache.add
- rocksdb.block.cache.data.miss
- rocksdb.block.cache.data.bytes.insert
- rocksdb.block.cache.data.add
- rocksdb.block.cache.hit
- rocksdb.block.cache.data.hit
- rocksdb.block.cache.bytes.read

The db_bench statistics before and after the change are:

|1GB block read|Children      |Self  |Command          |Shared Object        |Symbol|
|---|---|---|---|---|---|
|master:     |4.22%     |1.31%  |db_bench  |db_bench  |[.] rocksdb::StatisticsImpl::recordTick|
|updated:    |0.51%     |0.21%  |db_bench  |db_bench  |[.] rocksdb::StatisticsImpl::recordTick|
|     	     |0.14%     |0.14%  |db_bench  |db_bench  |[.] rocksdb::GetContext::record_counters|

|1MB block read|Children      |Self  |Command          |Shared Object        |Symbol|
|---|---|---|---|---|---|
|master:    |3.48%     |1.08%  |db_bench  |db_bench  |[.] rocksdb::StatisticsImpl::recordTick|
|updated:    |0.80%     |0.31%  |db_bench  |db_bench  |[.] rocksdb::StatisticsImpl::recordTick|
|    	     |0.35%     |0.35%  |db_bench  |db_bench  |[.] rocksdb::GetContext::record_counters|
Closes https://github.com/facebook/rocksdb/pull/3172

Differential Revision: D6330532

Pulled By: miasantreble

fbshipit-source-id: 2b492959e00a3db29e9437ecdcc5e48ca4ec5741
2017-12-14 16:52:06 -08:00
..
adaptive_table_factory.cc
Support prefetch last 512KB with direct I/O in block based file reader
2017-08-11 12:16:45 -07:00
adaptive_table_factory.h
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
block_based_filter_block_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
block_based_filter_block.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
block_based_filter_block.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
block_based_table_builder.cc
NUMBER_BLOCK_COMPRESSED, etc, shouldn't be treated as timer counter
2017-12-14 16:51:13 -08:00
block_based_table_builder.h
TableProperty::oldest_key_time defaults to 0
2017-10-27 15:00:05 -07:00
block_based_table_factory.cc
Support for block_cache num_shards and other config via option string.
2017-11-28 10:48:53 -08:00
block_based_table_factory.h
Replace dynamic_cast<>
2017-07-28 16:27:16 -07:00
block_based_table_reader.cc
Reduce heavy hitter for Get operation
2017-12-14 16:52:06 -08:00
block_based_table_reader.h
Reduce heavy hitter for Get operation
2017-12-14 16:52:06 -08:00
block_builder.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
block_builder.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
block_prefix_index.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
block_prefix_index.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
block_test.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
block.cc
table: Fix coverity issues
2017-12-07 11:57:36 -08:00
block.h
table/block.h: change memset
2017-07-17 10:41:56 -07:00
bloom_block.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
bloom_block.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
cleanable_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
cuckoo_table_builder_test.cc
allow nullptr Slice only as sentinel
2017-08-23 10:56:06 -07:00
cuckoo_table_builder.cc
Enable MSVC W4 with a few exceptions. Fix warnings and bugs
2017-10-19 10:57:12 -07:00
cuckoo_table_builder.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
cuckoo_table_factory.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
cuckoo_table_factory.h
Replace dynamic_cast<>
2017-07-28 16:27:16 -07:00
cuckoo_table_reader_test.cc
fix gflags namespace
2017-12-01 10:42:05 -08:00
cuckoo_table_reader.cc
table: Fix coverity issues
2017-12-07 11:57:36 -08:00
cuckoo_table_reader.h
remove unnecessary internal_comparator param in newIterator
2017-07-27 14:30:42 -07:00
filter_block.h
Extend pin_l0 to filter partitions
2017-08-23 07:56:08 -07:00
flush_block_policy.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
format.cc
NUMBER_BLOCK_COMPRESSED, etc, shouldn't be treated as timer counter
2017-12-14 16:51:13 -08:00
format.h
Support prefetch last 512KB with direct I/O in block based file reader
2017-08-11 12:16:45 -07:00
full_filter_bits_builder.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
full_filter_block_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
full_filter_block.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
full_filter_block.h
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
get_context.cc
Reduce heavy hitter for Get operation
2017-12-14 16:52:06 -08:00
get_context.h
Reduce heavy hitter for Get operation
2017-12-14 16:52:06 -08:00
index_builder.cc
Enable MSVC W4 with a few exceptions. Fix warnings and bugs
2017-10-19 10:57:12 -07:00
index_builder.h
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
internal_iterator.h
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
iter_heap.h
Make InternalKeyComparator final and directly use it in merging iterator
2017-09-11 12:04:21 -07:00
iterator_wrapper.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
iterator.cc
PinnableSlice move assignment
2017-10-12 18:28:24 -07:00
merger_test.cc
Make InternalKeyComparator final and directly use it in merging iterator
2017-09-11 12:04:21 -07:00
merging_iterator.cc
fix DBImpl::NewInternalIterator super-version leak on failure
2017-10-11 14:57:43 -07:00
merging_iterator.h
fix DBImpl::NewInternalIterator super-version leak on failure
2017-10-11 14:57:43 -07:00
meta_blocks.cc
Revert "No need for Restart Interval for meta blocks"
2017-11-20 16:42:03 -08:00
meta_blocks.h
Support prefetch last 512KB with direct I/O in block based file reader
2017-08-11 12:16:45 -07:00
mock_table.cc
remove unnecessary internal_comparator param in newIterator
2017-07-27 14:30:42 -07:00
mock_table.h
remove unnecessary internal_comparator param in newIterator
2017-07-27 14:30:42 -07:00
partitioned_filter_block_test.cc
Reduce heavy hitter for Get operation
2017-12-14 16:52:06 -08:00
partitioned_filter_block.cc
Reduce heavy hitter for Get operation
2017-12-14 16:52:06 -08:00
partitioned_filter_block.h
Extend pin_l0 to filter partitions
2017-08-23 07:56:08 -07:00
persistent_cache_helper.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
persistent_cache_helper.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
persistent_cache_options.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
plain_table_builder.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
plain_table_builder.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
plain_table_factory.cc
Allow upgrades from nullptr to some merge operator
2017-10-04 09:57:23 -07:00
plain_table_factory.h
Enable MSVC W4 with a few exceptions. Fix warnings and bugs
2017-10-19 10:57:12 -07:00
plain_table_index.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
plain_table_index.h
table: Fix coverity issues
2017-12-07 11:57:36 -08:00
plain_table_key_coding.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
plain_table_key_coding.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
plain_table_reader.cc
Support prefetch last 512KB with direct I/O in block based file reader
2017-08-11 12:16:45 -07:00
plain_table_reader.h
remove unnecessary internal_comparator param in newIterator
2017-07-27 14:30:42 -07:00
scoped_arena_iterator.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
sst_file_writer_collectors.h
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
sst_file_writer.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
table_builder.h
TableProperty::oldest_key_time defaults to 0
2017-10-27 15:00:05 -07:00
table_properties_internal.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
table_properties.cc
Add DB::Properties::kEstimateOldestKeyTime
2017-10-23 15:27:27 -07:00
table_reader_bench.cc
fix gflags namespace
2017-12-01 10:42:05 -08:00
table_reader.h
add VerifyChecksum() to db.h
2017-08-09 15:58:13 -07:00
table_test.cc
Preload l0 index partitions
2017-08-18 10:56:20 -07:00
two_level_iterator.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
two_level_iterator.h
Change RocksDB License
2017-07-15 16:11:23 -07:00