c7aedf1b48
Summary: * Add missing unit test for schema stability of FileChecksumGenCrc32c (previously was only comparing to itself) * A lot of clarifying comments * Add some assertions for preconditions * Rename WritableFileWriter::CalculateFileChecksum -> UpdateFileChecksum * Simplify FileChecksumGenCrc32c with shared functions * Implement EndianSwapValue to replace unused EndianTransform And incidentally since I had trouble with 'make check-format' GitHub action disagreeing with local run, * Output full diagnostic information when 'make check-format' fails in CI Pull Request resolved: https://github.com/facebook/rocksdb/pull/6861 Test Plan: new unit test passes before & after other changes Reviewed By: zhichao-cao Differential Revision: D21667115 Pulled By: pdillinger fbshipit-source-id: 6a99970f87605aa024fa540c78cd519ff322c3e6
88 lines
2.7 KiB
C++
88 lines
2.7 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#pragma once
|
|
#include <cassert>
|
|
#include <unordered_map>
|
|
|
|
#include "port/port.h"
|
|
#include "rocksdb/file_checksum.h"
|
|
#include "rocksdb/status.h"
|
|
#include "util/coding.h"
|
|
#include "util/crc32c.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
// This is the class to generate the file checksum based on Crc32. It
|
|
// will be used as the default checksum method for SST file checksum
|
|
class FileChecksumGenCrc32c : public FileChecksumGenerator {
|
|
public:
|
|
FileChecksumGenCrc32c(const FileChecksumGenContext& /*context*/) {
|
|
checksum_ = 0;
|
|
}
|
|
|
|
void Update(const char* data, size_t n) override {
|
|
checksum_ = crc32c::Extend(checksum_, data, n);
|
|
}
|
|
|
|
void Finalize() override {
|
|
assert(checksum_str_.empty());
|
|
// Store as big endian raw bytes
|
|
PutFixed32(&checksum_str_, EndianSwapValue(checksum_));
|
|
}
|
|
|
|
std::string GetChecksum() const override {
|
|
assert(!checksum_str_.empty());
|
|
return checksum_str_;
|
|
}
|
|
|
|
const char* Name() const override { return "FileChecksumCrc32c"; }
|
|
|
|
private:
|
|
uint32_t checksum_;
|
|
std::string checksum_str_;
|
|
};
|
|
|
|
class FileChecksumGenCrc32cFactory : public FileChecksumGenFactory {
|
|
public:
|
|
std::unique_ptr<FileChecksumGenerator> CreateFileChecksumGenerator(
|
|
const FileChecksumGenContext& context) override {
|
|
return std::unique_ptr<FileChecksumGenerator>(
|
|
new FileChecksumGenCrc32c(context));
|
|
}
|
|
|
|
const char* Name() const override { return "FileChecksumGenCrc32cFactory"; }
|
|
};
|
|
|
|
// The default implementaion of FileChecksumList
|
|
class FileChecksumListImpl : public FileChecksumList {
|
|
public:
|
|
FileChecksumListImpl() {}
|
|
void reset() override;
|
|
|
|
size_t size() const override;
|
|
|
|
Status GetAllFileChecksums(
|
|
std::vector<uint64_t>* file_numbers, std::vector<std::string>* checksums,
|
|
std::vector<std::string>* checksum_func_names) override;
|
|
|
|
Status SearchOneFileChecksum(uint64_t file_number, std::string* checksum,
|
|
std::string* checksum_func_name) override;
|
|
|
|
Status InsertOneFileChecksum(uint64_t file_number,
|
|
const std::string& checksum,
|
|
const std::string& checksum_func_name) override;
|
|
|
|
Status RemoveOneFileChecksum(uint64_t file_number) override;
|
|
|
|
private:
|
|
// Key is the file number, the first portion of the value is checksum, the
|
|
// second portion of the value is checksum function name.
|
|
std::unordered_map<uint64_t, std::pair<std::string, std::string>>
|
|
checksum_map_;
|
|
};
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|