b555ed30a4
Summary: Use a customzied BlockBasedTableIterator and LevelIterator to replace current implementations leveraging two-level-iterator. Hope the customized logic will make code easier to understand. As a side effect, BlockBasedTableIterator reduces the allocation for the data block iterator object, and avoid the virtual function call to it, because we can directly reference BlockIter, a final class. Similarly, LevelIterator reduces virtual function call to the dummy iterator iterating the file metadata. It also enabled further optimization. The upper bound check is also moved from index block to data block. This implementation fits this iterator better. After the change, forwared iterator is slightly optimized to ensure we trim those iterators. The two-level-iterator now is only used by partitioned index, so it is simplified. Closes https://github.com/facebook/rocksdb/pull/3406 Differential Revision: D6809041 Pulled By: siying fbshipit-source-id: 7da3b9b1d3c8e9d9405302c15920af1fcaf50ffa
47 lines
1.8 KiB
C++
47 lines
1.8 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
//
|
|
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
|
|
#pragma once
|
|
#include "rocksdb/iterator.h"
|
|
#include "rocksdb/env.h"
|
|
#include "table/iterator_wrapper.h"
|
|
|
|
namespace rocksdb {
|
|
|
|
struct ReadOptions;
|
|
class InternalKeyComparator;
|
|
class Arena;
|
|
|
|
struct TwoLevelIteratorState {
|
|
TwoLevelIteratorState() {}
|
|
|
|
virtual ~TwoLevelIteratorState() {}
|
|
virtual InternalIterator* NewSecondaryIterator(const Slice& handle) = 0;
|
|
};
|
|
|
|
|
|
// Return a new two level iterator. A two-level iterator contains an
|
|
// index iterator whose values point to a sequence of blocks where
|
|
// each block is itself a sequence of key,value pairs. The returned
|
|
// two-level iterator yields the concatenation of all key/value pairs
|
|
// in the sequence of blocks. Takes ownership of "index_iter" and
|
|
// will delete it when no longer needed.
|
|
//
|
|
// Uses a supplied function to convert an index_iter value into
|
|
// an iterator over the contents of the corresponding block.
|
|
// arena: If not null, the arena is used to allocate the Iterator.
|
|
// When destroying the iterator, the destructor will destroy
|
|
// all the states but those allocated in arena.
|
|
// need_free_iter_and_state: free `state` and `first_level_iter` if
|
|
// true. Otherwise, just call destructor.
|
|
extern InternalIterator* NewTwoLevelIterator(
|
|
TwoLevelIteratorState* state, InternalIterator* first_level_iter);
|
|
|
|
} // namespace rocksdb
|