Jay Zhuang
fa92b9dc9f
Fix TSAN build and re-enable the tests (#7386)
Summary:
Resolve TSAN build warnings and re-enable disabled TSAN tests.
Not sure if it's a compiler issue or TSAN check issue. Switching from
conditional operator to if-else mitigated the problem.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/7386
Test Plan:
run TSAN check 10 times in circleci.
```
WARNING: ThreadSanitizer: data race (pid=27735)
Atomic write of size 8 at 0x7b54000005e8 by thread T32:
#0 __tsan_atomic64_store <null> (db_test+0x4cee95)
https://github.com/facebook/rocksdb/issues/1 std::__atomic_base<unsigned long>::store(unsigned long, std::memory_order) /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/atomic_base.h:374:2 (db_test+0x78460e)
https://github.com/facebook/rocksdb/issues/2 rocksdb::VersionSet::SetLastSequence(unsigned long) /home/circleci/project/./db/version_set.h:1058:20 (db_test+0x78460e)
...
Previous read of size 8 at 0x7b54000005e8 by thread T31:
#0 bool rocksdb::DBImpl::MultiCFSnapshot<std::unordered_map<unsigned int, rocksdb::DBImpl::MultiGetColumnFamilyData, std::hash<unsigned int>, std::equal_to<unsigned int>, std::allocator<std::pair<unsigned int const, rocksdb::DBImpl::MultiGetColumnFamilyData> > > >(rocksdb::ReadOptions const&, rocksdb::ReadCallback*, std::function<rocksdb::DBImpl::MultiGetColumnFamilyData* (std::unordered_map<unsigned int, rocksdb::DBImpl::MultiGetColumnFamilyData, std::hash<unsigned int>, std::equal_to<unsigned int>, std::allocator<std::pair<unsigned int const, rocksdb::DBImpl::MultiGetColumnFamilyData> > >::iterator&)>&, std::unordered_map<unsigned int, rocksdb::DBImpl::MultiGetColumnFamilyData, std::hash<unsigned int>, std::equal_to<unsigned int>, std::allocator<std::pair<unsigned int const, rocksdb::DBImpl::MultiGetColumnFamilyData> > >*, unsigned long*) /home/circleci/project/db/db_impl/db_impl.cc (db_test+0x715087)
```
Reviewed By: ltamasi
Differential Revision: D23725226
Pulled By: jay-zhuang
fbshipit-source-id: a6d662a5ea68111246cd32ec95f3411a25f76bc6
2020-09-25 14:46:28 -07:00
..
2020-09-14 21:11:43 -07:00
2020-09-24 21:48:57 -07:00
2020-09-25 14:46:28 -07:00
2020-08-03 15:23:04 -07:00
2020-08-03 15:23:04 -07:00
2020-09-19 17:57:54 -07:00
2020-09-14 21:11:43 -07:00
2020-09-09 11:45:27 -07:00
2020-09-17 15:41:25 -07:00
2020-09-17 20:25:45 -07:00
2020-09-24 21:48:57 -07:00
2020-08-27 11:21:52 -07:00
2020-07-02 19:25:41 -07:00
2020-08-14 20:12:44 -07:00
2020-02-20 12:09:57 -08:00
2020-07-09 14:35:17 -07:00
2020-05-12 18:23:33 -07:00
2020-08-12 19:30:00 -07:00
2020-07-02 19:25:41 -07:00
2020-09-17 10:24:22 -07:00
2020-09-14 17:01:01 -07:00
2020-09-14 17:01:01 -07:00
2020-08-17 18:42:25 -07:00
2020-09-15 22:44:16 -07:00
2020-08-17 18:42:25 -07:00
2020-08-17 18:42:25 -07:00
2020-09-10 22:35:25 -07:00
2020-09-14 21:11:43 -07:00
2020-08-24 16:43:31 -07:00
2020-06-15 10:47:02 -07:00
2020-08-17 18:42:25 -07:00
2020-08-17 18:42:25 -07:00
2020-06-24 16:22:49 -07:00
2020-02-20 12:09:57 -08:00
2020-09-23 09:53:24 -07:00
2020-08-04 18:52:08 -07:00
2020-09-14 17:01:01 -07:00
2020-08-17 18:42:25 -07:00
2020-03-20 15:26:10 -07:00
2020-08-17 18:42:25 -07:00
2020-08-17 18:42:25 -07:00
2020-08-17 18:42:25 -07:00
2020-09-24 21:48:57 -07:00
2020-09-15 18:55:08 -07:00
2020-08-17 18:42:25 -07:00
2020-08-17 18:42:25 -07:00
2020-09-04 23:25:03 -07:00
2020-08-17 18:42:25 -07:00
2020-08-17 18:42:25 -07:00
2020-09-14 17:01:01 -07:00
2020-09-16 15:48:07 -07:00
2020-09-14 17:01:01 -07:00
2020-09-14 17:01:01 -07:00
2020-09-15 18:55:08 -07:00
2020-09-15 17:14:10 -07:00
2020-09-25 09:42:01 -07:00
2020-08-17 18:42:25 -07:00
2020-09-22 09:57:05 -07:00
2020-02-20 12:09:57 -08:00
2020-08-17 16:26:06 -07:00
2020-07-07 17:26:16 -07:00
2020-08-17 18:42:25 -07:00
2020-09-19 17:57:54 -07:00
2020-09-17 20:25:45 -07:00
2020-09-17 20:25:45 -07:00
2020-09-16 15:48:07 -07:00
2020-08-25 10:46:11 -07:00
2020-02-20 12:09:57 -08:00
2020-08-17 18:42:25 -07:00
2020-09-08 12:21:58 -07:00
2020-08-18 16:20:54 -07:00
2020-08-24 11:26:09 -07:00
2020-07-09 14:35:17 -07:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-08-06 17:19:41 -07:00
2020-09-08 10:56:08 -07:00
2020-09-14 21:11:43 -07:00
2020-09-08 10:56:08 -07:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-06-09 16:51:23 -07:00
2020-04-15 17:40:44 -07:00
2020-08-27 11:21:52 -07:00
2020-08-18 16:20:54 -07:00
2020-08-17 18:42:25 -07:00
2020-09-14 17:01:01 -07:00
2020-09-14 21:11:43 -07:00
2020-05-04 15:08:13 -07:00
2020-09-14 17:01:01 -07:00
2020-02-20 12:09:57 -08:00
2020-08-26 10:39:20 -07:00
2020-08-26 10:39:20 -07:00
2020-06-03 15:55:03 -07:00
2020-06-18 10:09:12 -07:00
2020-03-27 16:04:43 -07:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-03-04 20:15:25 -08:00
2020-09-24 21:48:57 -07:00
2020-09-14 21:11:43 -07:00
2020-08-21 13:29:05 -07:00
2020-08-05 10:44:57 -07:00
2020-03-02 16:01:00 -08:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-09-24 21:48:57 -07:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-08-17 18:42:25 -07:00
2020-09-16 15:48:07 -07:00
2020-04-20 13:24:25 -07:00
2020-02-20 12:09:57 -08:00
2020-07-09 14:35:17 -07:00
2020-02-20 12:09:57 -08:00
2020-08-10 10:48:05 -07:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-08-14 19:20:58 -07:00
2020-08-17 18:42:25 -07:00
2020-09-14 21:11:43 -07:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-08-27 11:21:52 -07:00
2020-08-27 11:21:52 -07:00
2020-09-14 17:01:01 -07:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-08-18 16:20:54 -07:00
2020-08-12 17:31:23 -07:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-09-09 10:25:12 -07:00
2020-09-09 10:25:12 -07:00
2020-06-09 16:51:23 -07:00
2020-09-08 10:56:08 -07:00
2020-09-08 10:56:08 -07:00
2020-09-22 14:35:14 -07:00
2020-09-14 21:11:43 -07:00
2020-09-14 21:11:43 -07:00
2020-08-12 17:31:23 -07:00
2020-09-08 10:56:08 -07:00
2020-09-25 14:46:28 -07:00
2020-09-25 13:25:54 -07:00
2020-09-25 13:25:54 -07:00
2020-09-25 13:25:54 -07:00
2020-08-12 17:31:23 -07:00
2020-08-18 16:20:54 -07:00
2020-08-12 17:31:23 -07:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-09-23 15:26:17 -07:00
2020-08-24 16:43:31 -07:00
2020-06-30 12:31:30 -07:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-02-20 12:09:57 -08:00
2020-09-11 07:58:31 -07:00
2020-08-20 19:18:35 -07:00