e0f9d11a05
Summary: Recently db_stress starts to use a special Env that keeps all manifest files. This should not apply to checkpoint directory and causes test failure like this: Verification failed: Checkpoint gave inconsistent state. Status is IO error: While mkdir: /dev/shm/rocksdb/rocksdb_crashtest_whitebox/.checkpoint27.tmp: File exists Pull Request resolved: https://github.com/facebook/rocksdb/pull/6233 Test Plan: Run crash_test with high chance of checkpoint and make sure it doesn't reproduce. Differential Revision: D19207250 fbshipit-source-id: 12a931379e2e0572bb84aa658b6d03770c8551d4
37 lines
1.3 KiB
C++
37 lines
1.3 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
//
|
|
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
|
|
#ifdef GFLAGS
|
|
#pragma once
|
|
#include "db_stress_tool/db_stress_common.h"
|
|
|
|
namespace rocksdb {
|
|
class DbStressEnvWrapper : public EnvWrapper {
|
|
public:
|
|
explicit DbStressEnvWrapper(Env* t) : EnvWrapper(t) {}
|
|
|
|
Status DeleteFile(const std::string& f) override {
|
|
// We determine whether it is a manifest file by searching a strong,
|
|
// so that there will be false positive if the directory path contains the
|
|
// keyword but it is unlikely.
|
|
// Checkpoint directory needs to be exempted.
|
|
if (!if_preserve_all_manifests ||
|
|
f.find("MANIFEST-") == std::string::npos ||
|
|
f.find("checkpoint") != std::string::npos) {
|
|
return target()->DeleteFile(f);
|
|
}
|
|
return Status::OK();
|
|
}
|
|
|
|
// If true, all manifest files will not be delted in DeleteFile().
|
|
bool if_preserve_all_manifests = true;
|
|
};
|
|
} // namespace rocksdb
|
|
#endif // GFLAGS
|