7d87f02799
Summary: This diff adds support for concurrent adds to the skiplist memtable implementations. Memory allocation is made thread-safe by the addition of a spinlock, with small per-core buffers to avoid contention. Concurrent memtable writes are made via an additional method and don't impose a performance overhead on the non-concurrent case, so parallelism can be selected on a per-batch basis. Write thread synchronization is an increasing bottleneck for higher levels of concurrency, so this diff adds --enable_write_thread_adaptive_yield (default off). This feature causes threads joining a write batch group to spin for a short time (default 100 usec) using sched_yield, rather than going to sleep on a mutex. If the timing of the yield calls indicates that another thread has actually run during the yield then spinning is avoided. This option improves performance for concurrent situations even without parallel adds, although it has the potential to increase CPU usage (and the heuristic adaptation is not yet mature). Parallel writes are not currently compatible with inplace updates, update callbacks, or delete filtering. Enable it with --allow_concurrent_memtable_write (and --enable_write_thread_adaptive_yield). Parallel memtable writes are performance neutral when there is no actual parallelism, and in my experiments (SSD server-class Linux and varying contention and key sizes for fillrandom) they are always a performance win when there is more than one thread. Statistics are updated earlier in the write path, dropping the number of DB mutex acquisitions from 2 to 1 for almost all cases. This diff was motivated and inspired by Yahoo's cLSM work. It is more conservative than cLSM: RocksDB's write batch group leader role is preserved (along with all of the existing flush and write throttling logic) and concurrent writers are blocked until all memtable insertions have completed and the sequence number has been advanced, to preserve linearizability. My test config is "db_bench -benchmarks=fillrandom -threads=$T -batch_size=1 -memtablerep=skip_list -value_size=100 --num=1000000/$T -level0_slowdown_writes_trigger=9999 -level0_stop_writes_trigger=9999 -disable_auto_compactions --max_write_buffer_number=8 -max_background_flushes=8 --disable_wal --write_buffer_size=160000000 --block_size=16384 --allow_concurrent_memtable_write" on a two-socket Xeon E5-2660 @ 2.2Ghz with lots of memory and an SSD hard drive. With 1 thread I get ~440Kops/sec. Peak performance for 1 socket (numactl -N1) is slightly more than 1Mops/sec, at 16 threads. Peak performance across both sockets happens at 30 threads, and is ~900Kops/sec, although with fewer threads there is less performance loss when the system has background work. Test Plan: 1. concurrent stress tests for InlineSkipList and DynamicBloom 2. make clean; make check 3. make clean; DISABLE_JEMALLOC=1 make valgrind_check; valgrind db_bench 4. make clean; COMPILE_WITH_TSAN=1 make all check; db_bench 5. make clean; COMPILE_WITH_ASAN=1 make all check; db_bench 6. make clean; OPT=-DROCKSDB_LITE make check 7. verify no perf regressions when disabled Reviewers: igor, sdong Reviewed By: sdong Subscribers: MarkCallaghan, IslamAbdelRahman, anthony, yhchiang, rven, sdong, guyg8, kradhakrishnan, dhruba Differential Revision: https://reviews.facebook.net/D50589
136 lines
5.0 KiB
C++
136 lines
5.0 KiB
C++
// Copyright (c) 2013, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under the BSD-style license found in the
|
|
// LICENSE file in the root directory of this source tree. An additional grant
|
|
// of patent rights can be found in the PATENTS file in the same directory.
|
|
//
|
|
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
|
|
// Arena is an implementation of Allocator class. For a request of small size,
|
|
// it allocates a block with pre-defined block size. For a request of big
|
|
// size, it uses malloc to directly get the requested size.
|
|
|
|
#pragma once
|
|
#ifndef OS_WIN
|
|
#include <sys/mman.h>
|
|
#endif
|
|
#include <cstddef>
|
|
#include <cerrno>
|
|
#include <vector>
|
|
#include <assert.h>
|
|
#include <stdint.h>
|
|
#include "util/allocator.h"
|
|
#include "util/mutexlock.h"
|
|
|
|
namespace rocksdb {
|
|
|
|
class Arena : public Allocator {
|
|
public:
|
|
// No copying allowed
|
|
Arena(const Arena&) = delete;
|
|
void operator=(const Arena&) = delete;
|
|
|
|
static const size_t kInlineSize = 2048;
|
|
static const size_t kMinBlockSize;
|
|
static const size_t kMaxBlockSize;
|
|
|
|
// huge_page_size: if 0, don't use huge page TLB. If > 0 (should set to the
|
|
// supported hugepage size of the system), block allocation will try huge
|
|
// page TLB first. If allocation fails, will fall back to normal case.
|
|
explicit Arena(size_t block_size = kMinBlockSize, size_t huge_page_size = 0);
|
|
~Arena();
|
|
|
|
char* Allocate(size_t bytes) override;
|
|
|
|
// huge_page_size: if >0, will try to allocate from huage page TLB.
|
|
// The argument will be the size of the page size for huge page TLB. Bytes
|
|
// will be rounded up to multiple of the page size to allocate through mmap
|
|
// anonymous option with huge page on. The extra space allocated will be
|
|
// wasted. If allocation fails, will fall back to normal case. To enable it,
|
|
// need to reserve huge pages for it to be allocated, like:
|
|
// sysctl -w vm.nr_hugepages=20
|
|
// See linux doc Documentation/vm/hugetlbpage.txt for details.
|
|
// huge page allocation can fail. In this case it will fail back to
|
|
// normal cases. The messages will be logged to logger. So when calling with
|
|
// huge_page_tlb_size > 0, we highly recommend a logger is passed in.
|
|
// Otherwise, the error message will be printed out to stderr directly.
|
|
char* AllocateAligned(size_t bytes, size_t huge_page_size = 0,
|
|
Logger* logger = nullptr) override;
|
|
|
|
// Returns an estimate of the total memory usage of data allocated
|
|
// by the arena (exclude the space allocated but not yet used for future
|
|
// allocations).
|
|
size_t ApproximateMemoryUsage() const {
|
|
return blocks_memory_ + blocks_.capacity() * sizeof(char*) -
|
|
alloc_bytes_remaining_;
|
|
}
|
|
|
|
size_t MemoryAllocatedBytes() const { return blocks_memory_; }
|
|
|
|
size_t AllocatedAndUnused() const { return alloc_bytes_remaining_; }
|
|
|
|
// If an allocation is too big, we'll allocate an irregular block with the
|
|
// same size of that allocation.
|
|
size_t IrregularBlockNum() const { return irregular_block_num; }
|
|
|
|
size_t BlockSize() const override { return kBlockSize; }
|
|
|
|
private:
|
|
char inline_block_[kInlineSize] __attribute__((__aligned__(sizeof(void*))));
|
|
// Number of bytes allocated in one block
|
|
const size_t kBlockSize;
|
|
// Array of new[] allocated memory blocks
|
|
typedef std::vector<char*> Blocks;
|
|
Blocks blocks_;
|
|
|
|
struct MmapInfo {
|
|
void* addr_;
|
|
size_t length_;
|
|
|
|
MmapInfo(void* addr, size_t length) : addr_(addr), length_(length) {}
|
|
};
|
|
std::vector<MmapInfo> huge_blocks_;
|
|
size_t irregular_block_num = 0;
|
|
|
|
// Stats for current active block.
|
|
// For each block, we allocate aligned memory chucks from one end and
|
|
// allocate unaligned memory chucks from the other end. Otherwise the
|
|
// memory waste for alignment will be higher if we allocate both types of
|
|
// memory from one direction.
|
|
char* unaligned_alloc_ptr_ = nullptr;
|
|
char* aligned_alloc_ptr_ = nullptr;
|
|
// How many bytes left in currently active block?
|
|
size_t alloc_bytes_remaining_ = 0;
|
|
|
|
#ifdef MAP_HUGETLB
|
|
size_t hugetlb_size_ = 0;
|
|
#endif // MAP_HUGETLB
|
|
char* AllocateFromHugePage(size_t bytes);
|
|
char* AllocateFallback(size_t bytes, bool aligned);
|
|
char* AllocateNewBlock(size_t block_bytes);
|
|
|
|
// Bytes of memory in blocks allocated so far
|
|
size_t blocks_memory_ = 0;
|
|
};
|
|
|
|
inline char* Arena::Allocate(size_t bytes) {
|
|
// The semantics of what to return are a bit messy if we allow
|
|
// 0-byte allocations, so we disallow them here (we don't need
|
|
// them for our internal use).
|
|
assert(bytes > 0);
|
|
if (bytes <= alloc_bytes_remaining_) {
|
|
unaligned_alloc_ptr_ -= bytes;
|
|
alloc_bytes_remaining_ -= bytes;
|
|
return unaligned_alloc_ptr_;
|
|
}
|
|
return AllocateFallback(bytes, false /* unaligned */);
|
|
}
|
|
|
|
// check and adjust the block_size so that the return value is
|
|
// 1. in the range of [kMinBlockSize, kMaxBlockSize].
|
|
// 2. the multiple of align unit.
|
|
extern size_t OptimizeBlockSize(size_t block_size);
|
|
|
|
} // namespace rocksdb
|