andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
fe9d495112
rocksdb/table/cuckoo
History
Peter Dillinger e92a0ed040 Optimize & clean up footer code (#9280) 
Summary:
Again, ahead of planned changes in https://github.com/facebook/rocksdb/issues/9058. This change improves
performance (vs. pre-https://github.com/facebook/rocksdb/issues/9240 baseline) by separating a FooterBuilder from
Footer, where FooterBuilder includes (inline owns) the serialized data
so that it can be stack allocated.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/9280

Test Plan:
existing tests + performance testing below

Extreme case performance testing as in https://github.com/facebook/rocksdb/issues/9240 with

    TEST_TMPDIR=/dev/shm/ ./db_bench -benchmarks=fillseq -memtablerep=vector -allow_concurrent_memtable_write=false -num=30000000

(Each is ops/s averaged over 50 runs, run simultaneously with competing
configuration for load fairness)
Pre-https://github.com/facebook/rocksdb/issues/9240 baseline (f577458): 436389
With https://github.com/facebook/rocksdb/issues/9240 (653c392): 417946 (-4.2% vs. baseline)
This change: 443762 (+1.7% vs. baseline)

Reviewed By: ajkr

Differential Revision: D33077220

Pulled By: pdillinger

fbshipit-source-id: 7eaa6499589aac1693414a758e8c799216c5016c
2021-12-13 17:43:07 -08:00
..
cuckoo_table_builder_test.cc Improve / clean up meta block code & integrity (#9163) 2021-11-18 11:43:44 -08:00
cuckoo_table_builder.cc Optimize & clean up footer code (#9280) 2021-12-13 17:43:07 -08:00
cuckoo_table_builder.h Embed original file number in SST table properties (#8686) 2021-08-20 20:40:48 -07:00
cuckoo_table_factory.cc Embed original file number in SST table properties (#8686) 2021-08-20 20:40:48 -07:00
cuckoo_table_factory.h Refactor: use TableBuilderOptions to reduce parameter lists (#8240) 2021-04-29 07:00:50 -07:00
cuckoo_table_reader_test.cc Cleanup includes in dbformat.h (#8930) 2021-09-29 04:04:40 -07:00
cuckoo_table_reader.cc Improve / clean up meta block code & integrity (#9163) 2021-11-18 11:43:44 -08:00
cuckoo_table_reader.h Cleanup includes in dbformat.h (#8930) 2021-09-29 04:04:40 -07:00