andreacavalli/scylla-jmx
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MetricsRegistry: Support both types of histograms

Browse Source 
There are two types of histograms, the older deprecated histogram and
the new estimated_histogram.

This patch changes the implementation of MetricsRegistry so the JmxTimer
would support both types, similiar to JmxHistogram.

Fixes #117

Signed-off-by: Amnon Heiman <amnon@scylladb.com>
This commit is contained in:
Amnon Heiman 2020-06-24 11:38:55 +03:00
parent b2195734cc
commit 6fef9d635e
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/main/java/org/apache/cassandra/metrics/MetricsRegistry.java
View File

@ -654,7 +654,11 @@ public class MetricsRegistry {
public void update(JsonObject obj) {
// TODO: this is not atomic.
super.update(obj.getJsonObject("meter"));
histogram = new Histogram(obj.getJsonObject("hist"));
if (obj.containsKey("hist")) {
histogram = new Histogram(obj.getJsonObject("hist"));
} else if (obj.containsKey("buckets")) {
histogram = new Histogram(new EstimatedHistogram(obj));
}
}
@Override