scylla-jmx

History

Amos Kong 01ba660fe7 sysconfig: correct the assignment in env file of systemd This commit `e80a5e3cb3` introduced an issue, it wrongly passes an empty string to scylla-jmx cmdline, which causes scylla-jmx script stuck. The cmdline real executes is: # scylla-jmx -l /usr/lib/scylla/jmx "" Wrapped quotation marks of env variable can't be parsed away if we use ${SCYLLA_PARAMS} in ExecStart cmdline, but $SCYLLA_PARAMS works. Another problem is the variable can't be re-used insider env file, reference: [1]. Let's split the parameters to multiple env variables, and combine them in ExecStart cmdline. [1] https://unix.stackexchange.com/questions/358998/systemd-environmentfile-re-using-variables-how Fixes scylladb/scylla#2935 Signed-off-by: Amos Kong <amos@scylladb.com> Message-Id: <c983103c08a3f901037fd282a14df5bb7f85dddd.1510494507.git.amos@scylladb.com>	2017-11-12 15:57:43 +02:00
..
scylla-jmx.service.in	sysconfig: correct the assignment in env file of systemd	2017-11-12 15:57:43 +02:00

Amos Kong 01ba660fe7 sysconfig: correct the assignment in env file of systemd

This commit e80a5e3cb3 introduced an issue,
it wrongly passes an empty string to scylla-jmx cmdline, which causes
scylla-jmx script stuck. The cmdline real executes is:

  # scylla-jmx -l /usr/lib/scylla/jmx ""

Wrapped quotation marks of env variable can't be parsed away if we use
${SCYLLA_PARAMS} in ExecStart cmdline, but $SCYLLA_PARAMS works.

Another problem is the variable can't be re-used insider env file,
reference: [1]. Let's split the parameters to multiple env variables,
and combine them in ExecStart cmdline.

[1] https://unix.stackexchange.com/questions/358998/systemd-environmentfile-re-using-variables-how

Fixes scylladb/scylla#2935

Signed-off-by: Amos Kong <amos@scylladb.com>
Message-Id: <c983103c08a3f901037fd282a14df5bb7f85dddd.1510494507.git.amos@scylladb.com>

2017-11-12 15:57:43 +02:00

scylla-jmx.service.in sysconfig: correct the assignment in env file of systemd 2017-11-12 15:57:43 +02:00