From 11c0fcc6ec698b0ec23dd82cb39c6bc912808c27 Mon Sep 17 00:00:00 2001
From: levlam <levlam@telegram.org>
Date: Thu, 1 Aug 2019 03:58:49 +0300
Subject: [PATCH] Do not create documents without file_id.

GitOrigin-RevId: c208baf37b108ffb256c3a39dee0459fc081f017
---
 td/telegram/AnimationsManager.cpp | 1 +
 td/telegram/AnimationsManager.hpp | 3 +++
 td/telegram/AudiosManager.cpp     | 1 +
 td/telegram/AudiosManager.hpp     | 3 +++
 td/telegram/DocumentsManager.cpp  | 1 +
 td/telegram/DocumentsManager.hpp  | 3 +++
 td/telegram/PollManager.hpp       | 3 +++
 td/telegram/StickersManager.cpp   | 1 +
 td/telegram/StickersManager.hpp   | 3 +++
 td/telegram/VideoNotesManager.cpp | 1 +
 td/telegram/VideoNotesManager.hpp | 3 +++
 td/telegram/VideosManager.cpp     | 1 +
 td/telegram/VideosManager.hpp     | 3 +++
 td/telegram/VoiceNotesManager.cpp | 1 +
 td/telegram/VoiceNotesManager.hpp | 3 +++
 15 files changed, 31 insertions(+)

diff --git a/td/telegram/AnimationsManager.cpp b/td/telegram/AnimationsManager.cpp
index 119606e5..fb0aa1fa 100644
--- a/td/telegram/AnimationsManager.cpp
+++ b/td/telegram/AnimationsManager.cpp
@@ -169,6 +169,7 @@ tl_object_ptr<td_api::animation> AnimationsManager::get_animation_object(FileId
 
 FileId AnimationsManager::on_get_animation(unique_ptr<Animation> new_animation, bool replace) {
   auto file_id = new_animation->file_id;
+  CHECK(file_id.is_valid());
   auto &a = animations_[file_id];
   LOG(INFO) << (a == nullptr ? "Add" : (replace ? "Replace" : "Ignore")) << " animation " << file_id << " of size "
             << new_animation->dimensions;
diff --git a/td/telegram/AnimationsManager.hpp b/td/telegram/AnimationsManager.hpp
index 204f844e..0853a330 100644
--- a/td/telegram/AnimationsManager.hpp
+++ b/td/telegram/AnimationsManager.hpp
@@ -45,6 +45,9 @@ FileId AnimationsManager::parse_animation(ParserT &parser) {
   }
   parse(animation->thumbnail, parser);
   parse(animation->file_id, parser);
+  if (parser.get_error() != nullptr || !animation->file_id.is_valid()) {
+    return FileId();
+  }
   return on_get_animation(std::move(animation), false);
 }
 
diff --git a/td/telegram/AudiosManager.cpp b/td/telegram/AudiosManager.cpp
index 7471436f..acb45a69 100644
--- a/td/telegram/AudiosManager.cpp
+++ b/td/telegram/AudiosManager.cpp
@@ -44,6 +44,7 @@ tl_object_ptr<td_api::audio> AudiosManager::get_audio_object(FileId file_id) {
 
 FileId AudiosManager::on_get_audio(unique_ptr<Audio> new_audio, bool replace) {
   auto file_id = new_audio->file_id;
+  CHECK(file_id.is_valid());
   LOG(INFO) << "Receive audio " << file_id;
   auto &a = audios_[file_id];
   if (a == nullptr) {
diff --git a/td/telegram/AudiosManager.hpp b/td/telegram/AudiosManager.hpp
index 02215d43..2b45c1a6 100644
--- a/td/telegram/AudiosManager.hpp
+++ b/td/telegram/AudiosManager.hpp
@@ -45,6 +45,9 @@ FileId AudiosManager::parse_audio(ParserT &parser) {
   }
   parse(audio->thumbnail, parser);
   parse(audio->file_id, parser);
+  if (parser.get_error() != nullptr || !audio->file_id.is_valid()) {
+    return FileId();
+  }
   return on_get_audio(std::move(audio), false);
 }
 
diff --git a/td/telegram/DocumentsManager.cpp b/td/telegram/DocumentsManager.cpp
index 3a29042b..c4834e02 100644
--- a/td/telegram/DocumentsManager.cpp
+++ b/td/telegram/DocumentsManager.cpp
@@ -437,6 +437,7 @@ Document DocumentsManager::on_get_document(RemoteDocument remote_document, Dialo
 
 FileId DocumentsManager::on_get_document(unique_ptr<GeneralDocument> new_document, bool replace) {
   auto file_id = new_document->file_id;
+  CHECK(file_id.is_valid());
   LOG(INFO) << "Receive document " << file_id;
   auto &d = documents_[new_document->file_id];
   if (d == nullptr) {
diff --git a/td/telegram/DocumentsManager.hpp b/td/telegram/DocumentsManager.hpp
index 64caa806..4900c1b1 100644
--- a/td/telegram/DocumentsManager.hpp
+++ b/td/telegram/DocumentsManager.hpp
@@ -41,6 +41,9 @@ FileId DocumentsManager::parse_document(ParserT &parser) {
   parse(document->thumbnail, parser);
   parse(document->file_id, parser);
   LOG(DEBUG) << "Parsed document " << document->file_id;
+  if (parser.get_error() != nullptr || !document->file_id.is_valid()) {
+    return FileId();
+  }
   return on_get_document(std::move(document), false);
 }
 
diff --git a/td/telegram/PollManager.hpp b/td/telegram/PollManager.hpp
index 2783851f..12834ac4 100644
--- a/td/telegram/PollManager.hpp
+++ b/td/telegram/PollManager.hpp
@@ -84,6 +84,9 @@ PollId PollManager::parse_poll(ParserT &parser) {
     vector<string> options;
     parse(question, parser);
     parse(options, parser);
+    if (parser.get_error() != nullptr) {
+      return PollId();
+    }
     return create_poll(std::move(question), std::move(options));
   }
 
diff --git a/td/telegram/StickersManager.cpp b/td/telegram/StickersManager.cpp
index 274f4d91..54366a51 100644
--- a/td/telegram/StickersManager.cpp
+++ b/td/telegram/StickersManager.cpp
@@ -1177,6 +1177,7 @@ tl_object_ptr<telegram_api::InputStickerSet> StickersManager::get_input_sticker_
 
 FileId StickersManager::on_get_sticker(unique_ptr<Sticker> new_sticker, bool replace) {
   auto file_id = new_sticker->file_id;
+  CHECK(file_id.is_valid());
   LOG(INFO) << "Receive sticker " << file_id;
   auto &s = stickers_[file_id];
   if (s == nullptr) {
diff --git a/td/telegram/StickersManager.hpp b/td/telegram/StickersManager.hpp
index 4c2ad31c..63f91775 100644
--- a/td/telegram/StickersManager.hpp
+++ b/td/telegram/StickersManager.hpp
@@ -105,6 +105,9 @@ FileId StickersManager::parse_sticker(bool in_sticker_set, ParserT &parser) {
     parse(sticker->y_shift, parser);
     parse(sticker->scale, parser);
   }
+  if (parser.get_error() != nullptr || !sticker->file_id.is_valid()) {
+    return FileId();
+  }
   return on_get_sticker(std::move(sticker), false);  // data in the database is always outdated
 }
 
diff --git a/td/telegram/VideoNotesManager.cpp b/td/telegram/VideoNotesManager.cpp
index af4ad21b..9002454e 100644
--- a/td/telegram/VideoNotesManager.cpp
+++ b/td/telegram/VideoNotesManager.cpp
@@ -46,6 +46,7 @@ tl_object_ptr<td_api::videoNote> VideoNotesManager::get_video_note_object(FileId
 
 FileId VideoNotesManager::on_get_video_note(unique_ptr<VideoNote> new_video_note, bool replace) {
   auto file_id = new_video_note->file_id;
+  CHECK(file_id.is_valid());
   LOG(INFO) << "Receive video note " << file_id;
   auto &v = video_notes_[file_id];
   if (v == nullptr) {
diff --git a/td/telegram/VideoNotesManager.hpp b/td/telegram/VideoNotesManager.hpp
index bfcea521..88fa86ef 100644
--- a/td/telegram/VideoNotesManager.hpp
+++ b/td/telegram/VideoNotesManager.hpp
@@ -39,6 +39,9 @@ FileId VideoNotesManager::parse_video_note(ParserT &parser) {
   }
   parse(video_note->thumbnail, parser);
   parse(video_note->file_id, parser);
+  if (parser.get_error() != nullptr || !video_note->file_id.is_valid()) {
+    return FileId();
+  }
   return on_get_video_note(std::move(video_note), false);
 }
 
diff --git a/td/telegram/VideosManager.cpp b/td/telegram/VideosManager.cpp
index ae705369..36c85098 100644
--- a/td/telegram/VideosManager.cpp
+++ b/td/telegram/VideosManager.cpp
@@ -46,6 +46,7 @@ tl_object_ptr<td_api::video> VideosManager::get_video_object(FileId file_id) {
 
 FileId VideosManager::on_get_video(unique_ptr<Video> new_video, bool replace) {
   auto file_id = new_video->file_id;
+  CHECK(file_id.is_valid());
   LOG(INFO) << "Receive video " << file_id;
   auto &v = videos_[file_id];
   if (v == nullptr) {
diff --git a/td/telegram/VideosManager.hpp b/td/telegram/VideosManager.hpp
index f5c263e5..844c3023 100644
--- a/td/telegram/VideosManager.hpp
+++ b/td/telegram/VideosManager.hpp
@@ -57,6 +57,9 @@ FileId VideosManager::parse_video(ParserT &parser) {
   if (video->has_stickers) {
     parse(video->sticker_file_ids, parser);
   }
+  if (parser.get_error() != nullptr || !video->file_id.is_valid()) {
+    return FileId();
+  }
   return on_get_video(std::move(video), false);
 }
 
diff --git a/td/telegram/VoiceNotesManager.cpp b/td/telegram/VoiceNotesManager.cpp
index df5a1454..85dfdf28 100644
--- a/td/telegram/VoiceNotesManager.cpp
+++ b/td/telegram/VoiceNotesManager.cpp
@@ -43,6 +43,7 @@ tl_object_ptr<td_api::voiceNote> VoiceNotesManager::get_voice_note_object(FileId
 
 FileId VoiceNotesManager::on_get_voice_note(unique_ptr<VoiceNote> new_voice_note, bool replace) {
   auto file_id = new_voice_note->file_id;
+  CHECK(file_id.is_valid());
   LOG(INFO) << "Receive voice note " << file_id;
   auto &v = voice_notes_[file_id];
   if (v == nullptr) {
diff --git a/td/telegram/VoiceNotesManager.hpp b/td/telegram/VoiceNotesManager.hpp
index be4bb7f6..089041da 100644
--- a/td/telegram/VoiceNotesManager.hpp
+++ b/td/telegram/VoiceNotesManager.hpp
@@ -33,6 +33,9 @@ FileId VoiceNotesManager::parse_voice_note(ParserT &parser) {
   parse(voice_note->duration, parser);
   parse(voice_note->waveform, parser);
   parse(voice_note->file_id, parser);
+  if (parser.get_error() != nullptr || !voice_note->file_id.is_valid()) {
+    return FileId();
+  }
   return on_get_voice_note(std::move(voice_note), false);
 }