From 5368c96a41994d8f5a4e75116878b046af346303 Mon Sep 17 00:00:00 2001
From: levlam <levlam@telegram.org>
Date: Thu, 25 Oct 2018 18:00:49 +0300
Subject: [PATCH] Add parse_message function.

GitOrigin-RevId: 8bada6f99333add3548317ccca2ca4b5c8bb2136
---
 td/telegram/MessagesManager.cpp | 36 +++++++++++++++++++++++++++------
 td/telegram/MessagesManager.h   |  2 ++
 2 files changed, 32 insertions(+), 6 deletions(-)

diff --git a/td/telegram/MessagesManager.cpp b/td/telegram/MessagesManager.cpp
index 0e0375c3..09740433 100644
--- a/td/telegram/MessagesManager.cpp
+++ b/td/telegram/MessagesManager.cpp
@@ -13770,6 +13770,22 @@ void MessagesManager::preload_older_messages(const Dialog *d, MessageId min_mess
   }
 }
 
+unique_ptr<MessagesManager::Message> MessagesManager::parse_message(const BufferSlice &value) {
+  LOG(INFO) << "Loaded message of size " << value.size() << " from database";
+  auto m = make_unique<Message>();
+
+  auto status = log_event_parse(*m, value.as_slice());
+  if (status.is_error() || !m->message_id.is_valid()) {
+    // can't happen unless database is broken, but has been seen in the wild
+
+    LOG(FATAL) << "Receive invalid message from database: " << m->message_id << ' ' << status << ' '
+               << format::as_hex_dump<4>(value.as_slice());
+    return nullptr;
+  }
+
+  return m;
+}
+
 void MessagesManager::on_get_history_from_database(DialogId dialog_id, MessageId from_message_id, int32 offset,
                                                    int32 limit, bool from_the_end, bool only_local,
                                                    vector<BufferSlice> &&messages, Promise<Unit> &&promise) {
@@ -13807,8 +13823,14 @@ void MessagesManager::on_get_history_from_database(DialogId dialog_id, MessageId
     if (!d->first_database_message_id.is_valid() && !d->have_full_history) {
       break;
     }
-    auto message = make_unique<Message>();
-    log_event_parse(*message, message_slice.as_slice()).ensure();
+    auto message = parse_message(std::move(message_slice));
+    if (message == nullptr) {
+      if (d->have_full_history) {
+        d->have_full_history = false;
+        on_dialog_updated(dialog_id, "drop have_full_history in on_get_history_from_database");
+      }
+      break;
+    }
     if (message->message_id.get() < d->first_database_message_id.get()) {
       if (d->have_full_history) {
         LOG(ERROR) << "Have full history in the " << dialog_id << " and receive " << message->message_id
@@ -19616,8 +19638,10 @@ MessagesManager::Message *MessagesManager::on_get_message_from_database(DialogId
     return nullptr;
   }
 
-  auto m = make_unique<Message>();
-  log_event_parse(*m, value.as_slice()).ensure();
+  auto m = parse_message(std::move(value));
+  if (m == nullptr) {
+    return nullptr;
+  }
 
   if (d == nullptr) {
     LOG(ERROR) << "Can't find " << dialog_id << ", but have a message from it";
@@ -21601,10 +21625,10 @@ unique_ptr<MessagesManager::Dialog> MessagesManager::parse_dialog(DialogId dialo
   if (status.is_error() || !d->dialog_id.is_valid()) {
     // can't happen unless database is broken, but has been seen in the wild
     // if dialog_id is invalid, we can't repair the dialog
-    CHECK(dialog_id.is_valid()) << "Can't repair " << dialog_id << " " << d->dialog_id << " "
+    CHECK(dialog_id.is_valid()) << "Can't repair " << dialog_id << ' ' << d->dialog_id << ' ' << status << ' '
                                 << format::as_hex_dump<4>(value.as_slice());
 
-    LOG(ERROR) << "Repair broken " << dialog_id << " " << format::as_hex_dump<4>(value.as_slice());
+    LOG(ERROR) << "Repair broken " << dialog_id << ' ' << format::as_hex_dump<4>(value.as_slice());
 
     // just clean all known data about the dialog
     d = make_unique<Dialog>();
diff --git a/td/telegram/MessagesManager.h b/td/telegram/MessagesManager.h
index c7d6b9ff..562e6d41 100644
--- a/td/telegram/MessagesManager.h
+++ b/td/telegram/MessagesManager.h
@@ -1834,6 +1834,8 @@ class MessagesManager : public Actor {
 
   string get_search_text(const Message *m) const;
 
+  static unique_ptr<Message> parse_message(const BufferSlice &value);
+
   unique_ptr<Dialog> parse_dialog(DialogId dialog_id, const BufferSlice &value);
 
   void load_calls_db_state();