From 5de928006b066c1cf2150db000cf14e6be407ac1 Mon Sep 17 00:00:00 2001 From: levlam Date: Mon, 22 Jul 2019 07:05:50 +0300 Subject: [PATCH] Fix GCC CE and warnings. GitOrigin-RevId: 21c7aa0f95f6534c8d8f1515fc93c67b55bb7998 --- benchmark/check_tls.cpp | 2 +- td/telegram/ConfigManager.cpp | 4 ++-- td/telegram/Td.cpp | 1 + tdutils/td/utils/port/stacktrace.cpp | 4 +++- tdutils/td/utils/port/stacktrace.h | 2 ++ 5 files changed, 9 insertions(+), 4 deletions(-) diff --git a/benchmark/check_tls.cpp b/benchmark/check_tls.cpp index 156d5d40..d88e611c 100644 --- a/benchmark/check_tls.cpp +++ b/benchmark/check_tls.cpp @@ -97,7 +97,7 @@ td::Result test_tls(const td::string &url) { // LOG(ERROR) << td::format::as_hex_dump<0>(td::Slice(request)); - socket.write(request); + TRY_STATUS(socket.write(request)); TlsInfo info; auto end_time = td::Time::now() + 3; diff --git a/td/telegram/ConfigManager.cpp b/td/telegram/ConfigManager.cpp index 8cc95d65..c645962f 100644 --- a/td/telegram/ConfigManager.cpp +++ b/td/telegram/ConfigManager.cpp @@ -212,7 +212,7 @@ static ActorOwn<> get_simple_config_impl(Promise promise, in SimpleConfigResult res; res.r_http_date = HttpDate::parse_http_date(http_query->get_header("date").str()); res.r_config = decode_config(http_query->content_); - return res; + return std::move(res); }()); }), std::move(url), std::vector>({{"Host", std::move(host)}}), timeout, ttl, prefer_ipv6, @@ -277,7 +277,7 @@ ActorOwn<> get_simple_config_google_dns(Promise promise, con } return decode_config(data); }(); - return res; + return std::move(res); }()); }), PSTRING() << "https://www.google.com/resolve?name=" << url_encode(name) << "&type=16", diff --git a/td/telegram/Td.cpp b/td/telegram/Td.cpp index 7b070220..bb0d7389 100644 --- a/td/telegram/Td.cpp +++ b/td/telegram/Td.cpp @@ -6784,6 +6784,7 @@ void Td::on_request(uint64 id, td_api::setOption &request) { })) { return; } + break; case 'd': if (!is_bot && set_boolean_option("disable_contact_registered_notifications")) { return; diff --git a/tdutils/td/utils/port/stacktrace.cpp b/tdutils/td/utils/port/stacktrace.cpp index 136b0f83..6463d478 100644 --- a/tdutils/td/utils/port/stacktrace.cpp +++ b/tdutils/td/utils/port/stacktrace.cpp @@ -77,7 +77,9 @@ void print_backtrace_gdb(void) { #if TD_LINUX && defined(PR_SET_PTRACER) if (need_set_ptracer) { char c; - read(fds[0], &c, 1); + if (read(fds[0], &c, 1) < 0) { + signal_safe_write("Failed to read from pipe\n"); + } } #endif dup2(2, 1); // redirect output to stderr diff --git a/tdutils/td/utils/port/stacktrace.h b/tdutils/td/utils/port/stacktrace.h index 05523ef7..fbc4e78f 100644 --- a/tdutils/td/utils/port/stacktrace.h +++ b/tdutils/td/utils/port/stacktrace.h @@ -12,6 +12,8 @@ class Stacktrace { public: struct PrintOptions { bool use_gdb = false; + PrintOptions() { + } }; static void print_to_stderr(const PrintOptions &options = PrintOptions()); };