From 0eb19f9437b7d8c19592e49eedb028771d300d80 Mon Sep 17 00:00:00 2001 From: Adam Jackson Date: Tue, 14 Apr 2009 10:54:25 -0400 Subject: [PATCH] xdmcp: Don't crash on X -query with more than 255 IP addresses. (#20675) You could be more clever than this, but the wire protocol says this really is an array of not more than 255 ARRAY8, so it's not just a matter of changing the types. --- os/xdmcp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/os/xdmcp.c b/os/xdmcp.c index cf9558679..c1d650d46 100644 --- a/os/xdmcp.c +++ b/os/xdmcp.c @@ -490,6 +490,8 @@ XdmcpRegisterConnection ( return; } } + if (ConnectionAddresses.length + 1 == 256) + return; newAddress = xalloc (addrlen * sizeof (CARD8)); if (!newAddress) return;