andreacavalli/xserver-multidpi
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

remove optional R3 backwards compatibility

Browse Source 
Remove the permitOldBugs flag, which enabled backwards compatbility with
broken R2/R3 era clients.
This commit is contained in:
Daniel Stone 2006-08-07 23:43:40 +03:00 committed by Daniel Stone
parent f54b71b772
commit 12dbd8a02f
7 changed files with 15 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Xext/mitmisc.c
View File

@ -42,8 +42,6 @@ in this Software without prior written authorization from The Open Group.
#include <X11/extensions/mitmiscstr.h> #include <X11/extensions/mitmiscstr.h>
#include "modinit.h" #include "modinit.h"
extern Bool permitOldBugs;
#if 0 #if 0
static unsigned char MITReqCode; static unsigned char MITReqCode;
#endif #endif
@ -90,12 +88,8 @@ ProcMITSetBugMode(client)
REQUEST(xMITSetBugModeReq); REQUEST(xMITSetBugModeReq);
REQUEST_SIZE_MATCH(xMITSetBugModeReq); REQUEST_SIZE_MATCH(xMITSetBugModeReq);
if ((stuff->onOff != xTrue) && (stuff->onOff != xFalse)) if (stuff->onOff != xFalse)
{ return BadRequest;
client->errorValue = stuff->onOff;
return BadValue;
}
permitOldBugs = stuff->onOff;
return(client->noClientException); return(client->noClientException);
} }
@ -110,7 +104,7 @@ ProcMITGetBugMode(client)
rep.type = X_Reply; rep.type = X_Reply;
rep.length = 0; rep.length = 0;
rep.sequenceNumber = client->sequence; rep.sequenceNumber = client->sequence;
rep.onOff = permitOldBugs; rep.onOff = FALSE;
if (client->swapped) { if (client->swapped) {
swaps(&rep.sequenceNumber, n); swaps(&rep.sequenceNumber, n);
swapl(&rep.length, n); swapl(&rep.length, n);

21
dix/events.c
View File

@ -3214,7 +3214,7 @@ EventSuppressForWindow(register WindowPtr pWin, register ClientPtr client,
{ {
register int i, free; register int i, free;
if ((mask & ~PropagateMask) && !permitOldBugs) if (mask & ~PropagateMask)
{ {
client->errorValue = mask; client->errorValue = mask;
return BadValue; return BadValue;
@ -3765,7 +3765,7 @@ ProcGrabPointer(ClientPtr client)
client->errorValue = stuff->ownerEvents; client->errorValue = stuff->ownerEvents;
return BadValue; return BadValue;
} }
if ((stuff->eventMask & ~PointerGrabMask) && !permitOldBugs) if (stuff->eventMask & ~PointerGrabMask)
{ {
client->errorValue = stuff->eventMask; client->errorValue = stuff->eventMask;
return BadValue; return BadValue;
@ -3851,7 +3851,7 @@ ProcChangeActivePointerGrab(ClientPtr client)
TimeStamp time; TimeStamp time;
REQUEST_SIZE_MATCH(xChangeActivePointerGrabReq); REQUEST_SIZE_MATCH(xChangeActivePointerGrabReq);
if ((stuff->eventMask & ~PointerGrabMask) && !permitOldBugs) if (stuff->eventMask & ~PointerGrabMask)
{ {
client->errorValue = stuff->eventMask; client->errorValue = stuff->eventMask;
return BadValue; return BadValue;
@ -4152,13 +4152,12 @@ ProcSendEvent(ClientPtr client)
if (stuff->event.u.u.type == ClientMessage && if (stuff->event.u.u.type == ClientMessage &&
stuff->event.u.u.detail != 8 && stuff->event.u.u.detail != 8 &&
stuff->event.u.u.detail != 16 && stuff->event.u.u.detail != 16 &&
stuff->event.u.u.detail != 32 && stuff->event.u.u.detail != 32)
!permitOldBugs)
{ {
client->errorValue = stuff->event.u.u.detail; client->errorValue = stuff->event.u.u.detail;
return BadValue; return BadValue;
} }
if ((stuff->eventMask & ~AllEventMasks) && !permitOldBugs) if (stuff->eventMask & ~AllEventMasks)
{ {
client->errorValue = stuff->eventMask; client->errorValue = stuff->eventMask;
return BadValue; return BadValue;
@ -4375,12 +4374,10 @@ ProcGrabButton(ClientPtr client)
grab = CreateGrab(client->index, inputInfo.pointer, pWin, grab = CreateGrab(client->index, inputInfo.pointer, pWin,
permitOldBugs ? (Mask)(stuff->eventMask | (Mask)stuff->eventMask, (Bool)stuff->ownerEvents,
ButtonPressMask | ButtonReleaseMask) : (Bool) stuff->keyboardMode, (Bool)stuff->pointerMode,
(Mask)stuff->eventMask, inputInfo.keyboard, stuff->modifiers, ButtonPress,
(Bool)stuff->ownerEvents, (Bool) stuff->keyboardMode, stuff->button, confineTo, cursor);
(Bool)stuff->pointerMode, inputInfo.keyboard, stuff->modifiers,
ButtonPress, stuff->button, confineTo, cursor);
if (!grab) if (!grab)
return BadAlloc; return BadAlloc;
return AddPassiveGrabToList(grab); return AddPassiveGrabToList(grab);

6
dix/globals.c
View File

@ -148,12 +148,6 @@ ClientPtr requestingClient; /* XXX this should be obsolete now, remove? */
_X_EXPORT TimeStamp currentTime; _X_EXPORT TimeStamp currentTime;
_X_EXPORT TimeStamp lastDeviceEventTime; _X_EXPORT TimeStamp lastDeviceEventTime;
/*
* turn off some error checking, to permit old broken clients (like R2/R3
* xterms) to work
*/
_X_EXPORT Bool permitOldBugs = FALSE;
_X_EXPORT int defaultColorVisualClass = -1; _X_EXPORT int defaultColorVisualClass = -1;
_X_EXPORT int monitorResolution = 0; _X_EXPORT int monitorResolution = 0;

6
dix/window.c
View File

@ -2093,7 +2093,7 @@ WhereDoIGoInTheStack(
else else
return NullWindow; return NullWindow;
case TopIf: case TopIf:
if ((!pWin->mapped || (pSib && !pSib->mapped)) && !permitOldBugs) if ((!pWin->mapped || (pSib && !pSib->mapped)))
return(pWin->nextSib); return(pWin->nextSib);
else if (pSib) else if (pSib)
{ {
@ -2108,7 +2108,7 @@ WhereDoIGoInTheStack(
else else
return(pWin->nextSib); return(pWin->nextSib);
case BottomIf: case BottomIf:
if ((!pWin->mapped || (pSib && !pSib->mapped)) && !permitOldBugs) if ((!pWin->mapped || (pSib && !pSib->mapped)))
return(pWin->nextSib); return(pWin->nextSib);
else if (pSib) else if (pSib)
{ {
@ -2123,7 +2123,7 @@ WhereDoIGoInTheStack(
else else
return(pWin->nextSib); return(pWin->nextSib);
case Opposite: case Opposite:
if ((!pWin->mapped || (pSib && !pSib->mapped)) && !permitOldBugs) if ((!pWin->mapped || (pSib && !pSib->mapped)))
return(pWin->nextSib); return(pWin->nextSib);
else if (pSib) else if (pSib)
{ {

1
hw/xfree86/loader/dixsym.c
View File

@ -244,7 +244,6 @@ _X_HIDDEN void *dixLookupTab[] = {
SYMVAR(globalSerialNumber) SYMVAR(globalSerialNumber)
SYMVAR(lastDeviceEventTime) SYMVAR(lastDeviceEventTime)
SYMVAR(monitorResolution) SYMVAR(monitorResolution)
SYMVAR(permitOldBugs)
SYMVAR(screenInfo) SYMVAR(screenInfo)
SYMVAR(serverClient) SYMVAR(serverClient)
SYMVAR(serverGeneration) SYMVAR(serverGeneration)

1
include/opaque.h
View File

@ -70,7 +70,6 @@ extern int limitStackSpace;
#ifdef RLIMIT_NOFILE #ifdef RLIMIT_NOFILE
extern int limitNoFile; extern int limitNoFile;
#endif #endif
extern Bool permitOldBugs;
extern Bool defeatAccessControl; extern Bool defeatAccessControl;
extern long maxBigRequestSize; extern long maxBigRequestSize;
extern Bool blackRoot; extern Bool blackRoot;

2
os/utils.c
View File

@ -768,8 +768,6 @@ ProcessCommandLine(int argc, char *argv[])
else else
UseMsg(); UseMsg();
} }
else if ( strcmp( argv[i], "bc") == 0)
permitOldBugs = TRUE;
else if ( strcmp( argv[i], "-br") == 0) else if ( strcmp( argv[i], "-br") == 0)
blackRoot = TRUE; blackRoot = TRUE;
else if ( strcmp( argv[i], "+bs") == 0) else if ( strcmp( argv[i], "+bs") == 0)