Fix pixmap validation in miDbePositionWindow.
miDbePositionWindow allocates two pixmaps: a front buffer, and a back buffer. If the buffers are supposed to be initialized, it validates a GC against the front buffer, then uses it to fill and/or copy both the front buffer *and* the back buffer, without revalidating. If the acceleration architecture needs different GC funcs for the two pixmaps -- for example if allocation of the front buffer exhausted video memory -- then this can cause crashes because the GC is not validated for the back buffer pixmap. Fix this by performing the rendering for the front buffer first, then revalidating against the back buffer before performing the back buffer rendering. Signed-off-by: Aaron Plattner <aplattner@nvidia.com> Reviewed-by: Jamey Sharp <jamey@minilop.net> Signed-off-by: Keith Packard <keithp@keithp.com>
This commit is contained in:
parent
91a6359caf
commit
1304b8b27c
20
dbe/midbe.c
20
dbe/midbe.c
|
@ -695,25 +695,33 @@ miDbePositionWindow(WindowPtr pWin, int x, int y)
|
|||
|
||||
|
||||
pDbeWindowPrivPriv = MI_DBE_WINDOW_PRIV_PRIV(pDbeWindowPriv);
|
||||
ValidateGC((DrawablePtr)pFrontBuffer, pGC);
|
||||
|
||||
/* I suppose this could avoid quite a bit of work if
|
||||
* it computed the minimal area required.
|
||||
*/
|
||||
ValidateGC(&pFrontBuffer->drawable, pGC);
|
||||
if (clear)
|
||||
{
|
||||
(*pGC->ops->PolyFillRect)((DrawablePtr)pFrontBuffer, pGC, 1,
|
||||
&clearRect);
|
||||
(*pGC->ops->PolyFillRect)((DrawablePtr)pBackBuffer , pGC, 1,
|
||||
&clearRect);
|
||||
}
|
||||
|
||||
/* Copy the contents of the old DBE pixmaps to the new pixmaps. */
|
||||
}
|
||||
/* Copy the contents of the old front pixmap to the new one. */
|
||||
if (pWin->bitGravity != ForgetGravity)
|
||||
{
|
||||
(*pGC->ops->CopyArea)((DrawablePtr)pDbeWindowPrivPriv->pFrontBuffer,
|
||||
(DrawablePtr)pFrontBuffer, pGC, sourcex,
|
||||
sourcey, savewidth, saveheight, destx, desty);
|
||||
}
|
||||
|
||||
ValidateGC(&pBackBuffer->drawable, pGC);
|
||||
if (clear)
|
||||
{
|
||||
(*pGC->ops->PolyFillRect)((DrawablePtr)pBackBuffer , pGC, 1,
|
||||
&clearRect);
|
||||
}
|
||||
/* Copy the contents of the old back pixmap to the new one. */
|
||||
if (pWin->bitGravity != ForgetGravity)
|
||||
{
|
||||
(*pGC->ops->CopyArea)((DrawablePtr)pDbeWindowPrivPriv->pBackBuffer,
|
||||
(DrawablePtr)pBackBuffer, pGC, sourcex,
|
||||
sourcey, savewidth, saveheight, destx, desty);
|
||||
|
|
Loading…
Reference in New Issue
Block a user