test: fix up InputAttributes helper function test.
Just some extra clarification as pointed out by Dan Nicholson, and that memcpy should have been a memcmp. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by: Dan Nicholson <dbn.lists@gmail.com>
This commit is contained in:
parent
6cccf0131c
commit
151659f963
|
@ -803,12 +803,18 @@ static void cmp_attr_fields(InputAttributes *attr1,
|
|||
|
||||
tags1 = attr1->tags;
|
||||
tags2 = attr2->tags;
|
||||
|
||||
/* if we don't have any tags, skip the tag checking bits */
|
||||
if (!tags1)
|
||||
{
|
||||
g_assert(!tags2);
|
||||
return;
|
||||
}
|
||||
|
||||
/* Don't lug around empty arrays */
|
||||
g_assert(*tags1);
|
||||
g_assert(*tags2);
|
||||
|
||||
/* check for identical content, but duplicated */
|
||||
while (*tags1)
|
||||
{
|
||||
|
@ -818,6 +824,7 @@ static void cmp_attr_fields(InputAttributes *attr1,
|
|||
tags2++;
|
||||
}
|
||||
|
||||
/* ensure tags1 and tags2 have the same no of elements */
|
||||
g_assert(!*tags2);
|
||||
|
||||
/* check for not sharing memory */
|
||||
|
@ -842,7 +849,7 @@ static void dix_input_attributes(void)
|
|||
g_assert(!new);
|
||||
|
||||
new = DuplicateInputAttributes(&orig);
|
||||
g_assert(memcpy(&orig, new, sizeof(InputAttributes)));
|
||||
g_assert(memcmp(&orig, new, sizeof(InputAttributes)) == 0);
|
||||
|
||||
orig.product = "product name";
|
||||
new = DuplicateInputAttributes(&orig);
|
||||
|
|
Loading…
Reference in New Issue
Block a user