andreacavalli/xserver-multidpi
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Xi: return BadDevice for slave devices on ProcXSetClientPointer

Browse Source 
Also clean up to return error codes instead of sending the error manually.
This commit is contained in:
Peter Hutterer 2007-11-08 10:00:35 +10:30
parent 184a7b8917
commit 180220f284
1 changed files with 9 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
Xi/setcptr.c
View File

@ -78,11 +78,10 @@ ProcXSetClientPointer(ClientPtr client)
pDev = LookupDeviceIntRec(stuff->deviceid); pDev = LookupDeviceIntRec(stuff->deviceid);
if (pDev == NULL || !IsPointerDevice(pDev)) if (pDev == NULL || !IsPointerDevice(pDev) || !pDev->isMaster)
{ {
SendErrorToClient(client, IReqCode, X_SetClientPointer, 0, client->errorValue = stuff->deviceid;
BadDevice); return BadDevice;
return Success;
} }
if (stuff->win != None) if (stuff->win != None)
@ -90,19 +89,18 @@ ProcXSetClientPointer(ClientPtr client)
err = dixLookupWindow(&pWin, stuff->win, client, DixReadWriteAccess); err = dixLookupWindow(&pWin, stuff->win, client, DixReadWriteAccess);
if (err != Success) if (err != Success)
{ {
SendErrorToClient(client, IReqCode, X_SetClientPointer, client->errorValue = stuff->win;
stuff->win, err); return err;
return Success;
} }
targetClient= wClient(pWin); targetClient= wClient(pWin);
} else } else
targetClient = client; targetClient = client;
if (!SetClientPointer(targetClient, client, pDev)) if (!SetClientPointer(targetClient, client, pDev))
{ {
SendErrorToClient(client, IReqCode, X_SetClientPointer, client->errorValue = stuff->win;
stuff->win, BadAccess); return BadAccess;
return Success;
} }
return Success; return Success;
} }