From 234fe391802b114e96d60a6630f717f8e4fb726c Mon Sep 17 00:00:00 2001 From: Jon TURNEY Date: Fri, 7 Nov 2014 13:38:20 +0000 Subject: [PATCH] hw/xwin: Report OS version in log Report OS version in log Report if WoW64 is in use Manifest for compatbility with Windows versions, so we don't get lied to by GetVersionEx() Also, make the description in the manifest a bit more generic Signed-off-by: Jon TURNEY Reviewed-by: Colin Harrison --- hw/xwin/Makefile.am | 1 + hw/xwin/XWin.exe.manifest | 16 ++++++++- hw/xwin/win.h | 6 ++++ hw/xwin/winos.c | 72 +++++++++++++++++++++++++++++++++++++++ hw/xwin/winprocarg.c | 1 + 5 files changed, 95 insertions(+), 1 deletion(-) create mode 100644 hw/xwin/winos.c diff --git a/hw/xwin/Makefile.am b/hw/xwin/Makefile.am index 9afde7e77..4da3d12a4 100644 --- a/hw/xwin/Makefile.am +++ b/hw/xwin/Makefile.am @@ -71,6 +71,7 @@ SRCS = InitInput.c \ winmsgwindow.c \ winmultiwindowclass.c \ winmultiwindowicons.c \ + winos.c \ winprefs.c \ winprefsyacc.y \ winprefslex.l \ diff --git a/hw/xwin/XWin.exe.manifest b/hw/xwin/XWin.exe.manifest index 477334fb3..bd44b1066 100755 --- a/hw/xwin/XWin.exe.manifest +++ b/hw/xwin/XWin.exe.manifest @@ -1,6 +1,6 @@ - The XWin X Windows server for Cygwin. + The XWin X Windows server true + + + + + + + + + + + + + + diff --git a/hw/xwin/win.h b/hw/xwin/win.h index d41d0012e..5710ea852 100644 --- a/hw/xwin/win.h +++ b/hw/xwin/win.h @@ -1195,6 +1195,12 @@ winDoRandRScreenSetSize(ScreenPtr pScreen, Bool winCreateMsgWindowThread(void); +/* + * winos.c + */ +void +winOS(void); + /* * END DDX and DIX Function Prototypes */ diff --git a/hw/xwin/winos.c b/hw/xwin/winos.c new file mode 100644 index 000000000..0d825bb83 --- /dev/null +++ b/hw/xwin/winos.c @@ -0,0 +1,72 @@ +/* + * Copyright (c) 2010-2014 Colin Harrison All Rights Reserved. + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the "Software"), + * to deal in the Software without restriction, including without limitation + * the rights to use, copy, modify, merge, publish, distribute, sublicense, + * and/or sell copies of the Software, and to permit persons to whom the + * Software is furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in + * all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL + * THE ABOVE LISTED COPYRIGHT HOLDER(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR + * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, + * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER + * DEALINGS IN THE SOFTWARE. + * + * Except as contained in this notice, the name(s) of the above copyright + * holders shall not be used in advertising or otherwise to promote the sale, + * use or other dealings in this Software without prior written authorization. + * + * Author: Colin Harrison + */ + +#ifdef HAVE_XWIN_CONFIG_H +#include +#endif +#include "win.h" + +typedef BOOL (WINAPI *LPFN_ISWOW64PROCESS)(HANDLE, PBOOL); + +static const char* +IsWow64(void) +{ +#ifdef __x86_64__ + return " (64-bit)"; +#else + WINBOOL bIsWow64; + LPFN_ISWOW64PROCESS fnIsWow64Process = + (LPFN_ISWOW64PROCESS) GetProcAddress(GetModuleHandle(TEXT("kernel32")), + "IsWow64Process"); + if (NULL != fnIsWow64Process) { + if (fnIsWow64Process(GetCurrentProcess(), &bIsWow64)) + return bIsWow64 ? " (WoW64)" : " (32-bit)"; + } + + /* OS doesn't support IsWow64Process() */ + return ""; +#endif +} + +/* + * Report the OS version + */ + +void +winOS(void) +{ + OSVERSIONINFOEX osvi = {0}; + + /* Get operating system version information */ + osvi.dwOSVersionInfoSize = sizeof(osvi); + GetVersionEx((LPOSVERSIONINFO)&osvi); + + ErrorF("OS: Windows NT %d.%d build %d%s\n", + (int)osvi.dwMajorVersion, (int)osvi.dwMinorVersion, + (int)osvi.dwBuildNumber, IsWow64()); +} diff --git a/hw/xwin/winprocarg.c b/hw/xwin/winprocarg.c index 65bba8159..73aa027d8 100644 --- a/hw/xwin/winprocarg.c +++ b/hw/xwin/winprocarg.c @@ -1200,6 +1200,7 @@ winLogVersionInfo(void) } } #endif + winOS(); if (strlen(BUILDERSTRING)) ErrorF("%s\n", BUILDERSTRING); ErrorF("Contact: %s\n", BUILDERADDR);