dix: do not send focus event when grab actually does not change
c67f2eac56
("dix: always send focus event on grab change") made dix always sent events when it's a NotifyGrab or NotifyUngrab, even if from == to, because 'from' can just come from a previous XSetInputFocus call. However, when an application calls XGrabKeyboard several times on the same window, we are now sending spurious FocusOut+FocusIn with NotifyGrab, even if the grab does not actually change. This makes screen readers for blind people spuriously emit activity events which disturb screen reading workflow when e.g. switching between menus. This commit avoids calling DoFocusEvents in that precise case, i.e. when oldWin is a previous grab and the new grab is the same window. Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org> Reviewed-by: Adam Jackson <ajax@redhat.com> (cherry picked from commit364d649815
)
This commit is contained in:
parent
f84ad08255
commit
271934db9f
|
@ -1532,7 +1532,9 @@ ActivatePointerGrab(DeviceIntPtr mouse, GrabPtr grab,
|
|||
mouse->spriteInfo->sprite->hotPhys.y = 0;
|
||||
ConfineCursorToWindow(mouse, grab->confineTo, FALSE, TRUE);
|
||||
}
|
||||
DoEnterLeaveEvents(mouse, mouse->id, oldWin, grab->window, NotifyGrab);
|
||||
if (! (grabinfo->grab && oldWin == grabinfo->grab->window
|
||||
&& oldWin == grab->window))
|
||||
DoEnterLeaveEvents(mouse, mouse->id, oldWin, grab->window, NotifyGrab);
|
||||
mouse->valuator->motionHintWindow = NullWindow;
|
||||
if (syncEvents.playingEvents)
|
||||
grabinfo->grabTime = syncEvents.time;
|
||||
|
@ -1642,7 +1644,9 @@ ActivateKeyboardGrab(DeviceIntPtr keybd, GrabPtr grab, TimeStamp time,
|
|||
oldWin = keybd->focus->win;
|
||||
if (keybd->valuator)
|
||||
keybd->valuator->motionHintWindow = NullWindow;
|
||||
if (oldWin)
|
||||
if (oldWin &&
|
||||
! (grabinfo->grab && oldWin == grabinfo->grab->window
|
||||
&& oldWin == grab->window))
|
||||
DoFocusEvents(keybd, oldWin, grab->window, NotifyGrab);
|
||||
if (syncEvents.playingEvents)
|
||||
grabinfo->grabTime = syncEvents.time;
|
||||
|
|
Loading…
Reference in New Issue
Block a user