andreacavalli/xserver-multidpi
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

sparcPromPathname2Node: free name when returning error, instead of leaking it

Browse Source 
Reported with other leaks found by cppcheck in bugzilla #50281
https://bugs.freedesktop.org/show_bug.cgi?id=50281

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Keith Packard <keithp@keithp.com>
This commit is contained in:
Alan Coopersmith 2013-02-10 10:24:59 -08:00
parent 174ccd8493
commit 2b361fbda5
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
hw/xfree86/os-support/bus/Sbus.c
View File

@ -617,8 +617,10 @@ sparcPromPathname2Node(const char *pathName)
return 0;
strcpy(name, pathName);
name[i + 1] = 0;
if (name[0] != '/')
if (name[0] != '/') {
free(name);
return 0;
}
p = strchr(name + 1, '/');
if (p)
*p = 0;
@ -629,8 +631,10 @@ sparcPromPathname2Node(const char *pathName)
*regstr++ = 0;
else
regstr = p;
if (name + 1 == regstr)
if (name + 1 == regstr) {
free(name);
return 0;
}
promGetSibling(0);
i = promWalkPathname2Node(name + 1, regstr, promRootNode, 0);
free(name);