diff --git a/Xext/mitmisc.c b/Xext/mitmisc.c index a11c9a8ad..924b88063 100644 --- a/Xext/mitmisc.c +++ b/Xext/mitmisc.c @@ -42,8 +42,6 @@ in this Software without prior written authorization from The Open Group. #include #include "modinit.h" -extern Bool permitOldBugs; - #if 0 static unsigned char MITReqCode; #endif @@ -90,12 +88,8 @@ ProcMITSetBugMode(client) REQUEST(xMITSetBugModeReq); REQUEST_SIZE_MATCH(xMITSetBugModeReq); - if ((stuff->onOff != xTrue) && (stuff->onOff != xFalse)) - { - client->errorValue = stuff->onOff; - return BadValue; - } - permitOldBugs = stuff->onOff; + if (stuff->onOff != xFalse) + return BadRequest; return(client->noClientException); } @@ -110,7 +104,7 @@ ProcMITGetBugMode(client) rep.type = X_Reply; rep.length = 0; rep.sequenceNumber = client->sequence; - rep.onOff = permitOldBugs; + rep.onOff = FALSE; if (client->swapped) { swaps(&rep.sequenceNumber, n); swapl(&rep.length, n); diff --git a/dix/events.c b/dix/events.c index e5ae3e6cf..f6524a329 100644 --- a/dix/events.c +++ b/dix/events.c @@ -3217,7 +3217,7 @@ EventSuppressForWindow(register WindowPtr pWin, register ClientPtr client, { register int i, free; - if ((mask & ~PropagateMask) && !permitOldBugs) + if (mask & ~PropagateMask) { client->errorValue = mask; return BadValue; @@ -3768,7 +3768,7 @@ ProcGrabPointer(ClientPtr client) client->errorValue = stuff->ownerEvents; return BadValue; } - if ((stuff->eventMask & ~PointerGrabMask) && !permitOldBugs) + if (stuff->eventMask & ~PointerGrabMask) { client->errorValue = stuff->eventMask; return BadValue; @@ -3854,7 +3854,7 @@ ProcChangeActivePointerGrab(ClientPtr client) TimeStamp time; REQUEST_SIZE_MATCH(xChangeActivePointerGrabReq); - if ((stuff->eventMask & ~PointerGrabMask) && !permitOldBugs) + if (stuff->eventMask & ~PointerGrabMask) { client->errorValue = stuff->eventMask; return BadValue; @@ -4155,13 +4155,12 @@ ProcSendEvent(ClientPtr client) if (stuff->event.u.u.type == ClientMessage && stuff->event.u.u.detail != 8 && stuff->event.u.u.detail != 16 && - stuff->event.u.u.detail != 32 && - !permitOldBugs) + stuff->event.u.u.detail != 32) { client->errorValue = stuff->event.u.u.detail; return BadValue; } - if ((stuff->eventMask & ~AllEventMasks) && !permitOldBugs) + if (stuff->eventMask & ~AllEventMasks) { client->errorValue = stuff->eventMask; return BadValue; @@ -4378,12 +4377,10 @@ ProcGrabButton(ClientPtr client) grab = CreateGrab(client->index, inputInfo.pointer, pWin, - permitOldBugs ? (Mask)(stuff->eventMask | - ButtonPressMask | ButtonReleaseMask) : - (Mask)stuff->eventMask, - (Bool)stuff->ownerEvents, (Bool) stuff->keyboardMode, - (Bool)stuff->pointerMode, inputInfo.keyboard, stuff->modifiers, - ButtonPress, stuff->button, confineTo, cursor); + (Mask)stuff->eventMask, (Bool)stuff->ownerEvents, + (Bool) stuff->keyboardMode, (Bool)stuff->pointerMode, + inputInfo.keyboard, stuff->modifiers, ButtonPress, + stuff->button, confineTo, cursor); if (!grab) return BadAlloc; return AddPassiveGrabToList(grab); diff --git a/dix/globals.c b/dix/globals.c index 19721062c..5b854aabc 100644 --- a/dix/globals.c +++ b/dix/globals.c @@ -148,12 +148,6 @@ ClientPtr requestingClient; /* XXX this should be obsolete now, remove? */ _X_EXPORT TimeStamp currentTime; _X_EXPORT TimeStamp lastDeviceEventTime; -/* - * turn off some error checking, to permit old broken clients (like R2/R3 - * xterms) to work - */ -_X_EXPORT Bool permitOldBugs = FALSE; - _X_EXPORT int defaultColorVisualClass = -1; _X_EXPORT int monitorResolution = 0; diff --git a/dix/window.c b/dix/window.c index 0bcbf4608..ebc6923fa 100644 --- a/dix/window.c +++ b/dix/window.c @@ -2093,7 +2093,7 @@ WhereDoIGoInTheStack( else return NullWindow; case TopIf: - if ((!pWin->mapped || (pSib && !pSib->mapped)) && !permitOldBugs) + if ((!pWin->mapped || (pSib && !pSib->mapped))) return(pWin->nextSib); else if (pSib) { @@ -2108,7 +2108,7 @@ WhereDoIGoInTheStack( else return(pWin->nextSib); case BottomIf: - if ((!pWin->mapped || (pSib && !pSib->mapped)) && !permitOldBugs) + if ((!pWin->mapped || (pSib && !pSib->mapped))) return(pWin->nextSib); else if (pSib) { @@ -2123,7 +2123,7 @@ WhereDoIGoInTheStack( else return(pWin->nextSib); case Opposite: - if ((!pWin->mapped || (pSib && !pSib->mapped)) && !permitOldBugs) + if ((!pWin->mapped || (pSib && !pSib->mapped))) return(pWin->nextSib); else if (pSib) { diff --git a/hw/xfree86/loader/dixsym.c b/hw/xfree86/loader/dixsym.c index 0e8bb89dd..22fe501f3 100644 --- a/hw/xfree86/loader/dixsym.c +++ b/hw/xfree86/loader/dixsym.c @@ -244,7 +244,6 @@ _X_HIDDEN void *dixLookupTab[] = { SYMVAR(globalSerialNumber) SYMVAR(lastDeviceEventTime) SYMVAR(monitorResolution) - SYMVAR(permitOldBugs) SYMVAR(screenInfo) SYMVAR(serverClient) SYMVAR(serverGeneration) diff --git a/include/opaque.h b/include/opaque.h index bb5bc5e53..4ccccd054 100644 --- a/include/opaque.h +++ b/include/opaque.h @@ -70,7 +70,6 @@ extern int limitStackSpace; #ifdef RLIMIT_NOFILE extern int limitNoFile; #endif -extern Bool permitOldBugs; extern Bool defeatAccessControl; extern long maxBigRequestSize; extern Bool blackRoot; diff --git a/os/utils.c b/os/utils.c index def12be49..7a4bd1175 100644 --- a/os/utils.c +++ b/os/utils.c @@ -768,8 +768,6 @@ ProcessCommandLine(int argc, char *argv[]) else UseMsg(); } - else if ( strcmp( argv[i], "bc") == 0) - permitOldBugs = TRUE; else if ( strcmp( argv[i], "-br") == 0) blackRoot = TRUE; else if ( strcmp( argv[i], "+bs") == 0)