Coverity #82: Dead variable elimination.

This commit is contained in:
Adam Jackson 2006-04-03 02:12:11 +00:00
parent 61926dbe59
commit 3f87aeefb4
2 changed files with 7 additions and 6 deletions

View File

@ -1,3 +1,8 @@
2006-04-02 Adam Jackson <ajax@freedesktop.org>
* os/xdmauth.c:
Coverity #82: Dead variable elimination.
2006-04-02 Adam Jackson <ajax@freedesktop.org> 2006-04-02 Adam Jackson <ajax@freedesktop.org>
* GL/glx/glxcmdsswap.c: * GL/glx/glxcmdsswap.c:

View File

@ -463,10 +463,9 @@ XdmFromID (XID id, unsigned short *data_lenp, char **datap)
int int
XdmRemoveCookie (unsigned short data_length, char *data) XdmRemoveCookie (unsigned short data_length, char *data)
{ {
XdmAuthorizationPtr auth, prev; XdmAuthorizationPtr auth;
XdmAuthKeyPtr key_bits, rho_bits; XdmAuthKeyPtr key_bits, rho_bits;
prev = 0;
switch (data_length) switch (data_length)
{ {
case 16: case 16:
@ -486,10 +485,7 @@ XdmRemoveCookie (unsigned short data_length, char *data)
if (XdmcpCompareKeys (rho_bits, &auth->rho) && if (XdmcpCompareKeys (rho_bits, &auth->rho) &&
XdmcpCompareKeys (key_bits, &auth->key)) XdmcpCompareKeys (key_bits, &auth->key))
{ {
if (prev) xdmAuth = auth->next;
prev->next = auth->next;
else
xdmAuth = auth->next;
xfree (auth); xfree (auth);
return 1; return 1;
} }