diff --git a/Xext/sleepuntil.c b/Xext/sleepuntil.c index 68a7a9bee..334c2784a 100644 --- a/Xext/sleepuntil.c +++ b/Xext/sleepuntil.c @@ -125,8 +125,7 @@ ClientSleepUntil(ClientPtr client, static void ClientAwaken(ClientPtr client, void *closure) { - if (!client->clientGone) - AttendClient(client); + AttendClient(client); } static int diff --git a/dix/dixutils.c b/dix/dixutils.c index 2983174a1..331ccfb96 100644 --- a/dix/dixutils.c +++ b/dix/dixutils.c @@ -662,14 +662,7 @@ ClientWakeup(ClientPtr client) if (q->client == client) { *prev = q->next; free(q); - if (client->clientGone) - /* Oops -- new zombie cleanup code ensures this only - * happens from inside CloseDownClient; don't want to - * recurse here... - */ - /* CloseDownClient(client) */ ; - else - AttendClient(client); + AttendClient(client); break; } prev = &q->next; diff --git a/os/connection.c b/os/connection.c index a1c42aede..85e0050d8 100644 --- a/os/connection.c +++ b/os/connection.c @@ -924,6 +924,14 @@ AttendClient(ClientPtr client) { OsCommPtr oc = (OsCommPtr) client->osPrivate; + if (client->clientGone) { + /* + * client is gone, so any pending requests will be dropped and its + * ignore count doesn't matter. + */ + return; + } + client->ignoreCount--; if (client->ignoreCount) return; diff --git a/record/record.c b/record/record.c index 757fde1fe..42aee324a 100644 --- a/record/record.c +++ b/record/record.c @@ -2362,9 +2362,9 @@ RecordDisableContext(RecordContextPtr pContext) if (!pContext->pRecordingClient->clientGone) { RecordAProtocolElement(pContext, NULL, XRecordEndOfData, NULL, 0, 0, 0); RecordFlushReplyBuffer(pContext, NULL, 0, NULL, 0); - /* Re-enable request processing on this connection. */ - AttendClient(pContext->pRecordingClient); } + /* Re-enable request processing on this connection. */ + AttendClient(pContext->pRecordingClient); for (pRCAP = pContext->pListOfRCAP; pRCAP; pRCAP = pRCAP->pNextRCAP) { RecordUninstallHooks(pRCAP, 0);