From 52aa0495218dc7821a23b045b2c74b2a66e34616 Mon Sep 17 00:00:00 2001 From: Matt Turner Date: Mon, 31 Aug 2009 15:52:39 -0400 Subject: [PATCH] Replace 8 nops with proper sync instruction on mips Cc: Ralf Baechle Acked-by: David Daney Signed-off-by: Matt Turner --- hw/xfree86/common/compiler.h | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/hw/xfree86/common/compiler.h b/hw/xfree86/common/compiler.h index 114c81215..3b648df15 100644 --- a/hw/xfree86/common/compiler.h +++ b/hw/xfree86/common/compiler.h @@ -165,16 +165,17 @@ extern unsigned short ldw_brx(volatile unsigned char *, int); # endif # elif defined __mips__ -# define mem_barrier() \ - __asm__ __volatile__( \ - "# prevent instructions being moved around\n\t" \ - ".set\tnoreorder\n\t" \ - "# 8 nops to fool the R4400 pipeline\n\t" \ - "nop;nop;nop;nop;nop;nop;nop;nop\n\t" \ - ".set\treorder" \ - : /* no output */ \ - : /* no input */ \ - : "memory") + /* Note: sync instruction requires MIPS II instruction set */ +# define mem_barrier() \ + __asm__ __volatile__( \ + ".set push\n\t" \ + ".set noreorder\n\t" \ + ".set mips2\n\t" \ + "sync\n\t" \ + ".set pop" \ + : /* no output */ \ + : /* no input */ \ + : "memory") # define write_mem_barrier() mem_barrier() # elif defined __powerpc__