From 6115d8b40ce0c91620b6d5e7d18e0da704409f89 Mon Sep 17 00:00:00 2001 From: Chris Wilson Date: Sun, 15 Apr 2018 15:40:04 +0100 Subject: [PATCH] os/WaitFor: Use xorg_list_append() Currently, we use xorg_list_add(new, head->prev) which is functionaly equivalent to xorg_list_append(), but with more pointer chasing, so reduce the strain on the reader and compiler by using the simpler append(). Reviewed-by: Adam Jackson Signed-off-by: Chris Wilson --- os/WaitFor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/os/WaitFor.c b/os/WaitFor.c index 7c7b1d2d4..e3b545b93 100644 --- a/os/WaitFor.c +++ b/os/WaitFor.c @@ -332,7 +332,7 @@ TimerSet(OsTimerPtr timer, int flags, CARD32 millis, if ((int) (existing->expires - millis) > 0) break; /* This even works at the end of the list -- existing->list will be timers */ - xorg_list_add(&timer->list, existing->list.prev); + xorg_list_append(&timer->list, &existing->list); /* Check to see if the timer is ready to run now */ if ((int) (millis - now) <= 0)