From 6227f07b69b8ab3cd39cf9d257daf2a7202b4ef5 Mon Sep 17 00:00:00 2001 From: Alan Coopersmith Date: Tue, 11 Mar 2014 17:28:10 -0700 Subject: [PATCH] Remove duplicate assignment of repeat_type_uniform_location Flagged by cppcheck 1.64: [glamor/glamor_gradient.c:987] -> [glamor/glamor_gradient.c:991]: (performance) Variable 'repeat_type_uniform_location' is reassigned a value before the old one has been used. Signed-off-by: Alan Coopersmith Reviewed-by: Eric Anholt Signed-off-by: Eric Anholt --- glamor/glamor_gradient.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/glamor/glamor_gradient.c b/glamor/glamor_gradient.c index baa4a03f0..0769eaeaa 100644 --- a/glamor/glamor_gradient.c +++ b/glamor/glamor_gradient.c @@ -983,8 +983,6 @@ glamor_generate_radial_gradient_picture(ScreenPtr screen, "repeat_type"); n_stop_uniform_location = glGetUniformLocation(gradient_prog, "n_stop"); A_value_uniform_location = glGetUniformLocation(gradient_prog, "A_value"); - repeat_type_uniform_location =glGetUniformLocation(gradient_prog, - "repeat_type"); c1_uniform_location = glGetUniformLocation(gradient_prog, "c1"); r1_uniform_location = glGetUniformLocation(gradient_prog, "r1"); c2_uniform_location = glGetUniformLocation(gradient_prog, "c2");