From 6acd0d098add5a14f23d326ac6ee8cebab14b86a Mon Sep 17 00:00:00 2001 From: Adam Jackson Date: Wed, 17 Aug 2016 10:32:28 -0400 Subject: [PATCH] test: Remember to swap the window argument to XIQueryPointer MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Before 5c69cb60 this wouldn't matter, because ProcXIQueryPointer manually emitted its own error before (bogusly) returning Success to the main loop. Since these tests only look at the return value of the dispatch function we'd think things succeeded even when we'd generated an error. With that fixed, the test code's failure to swap the window id would make dixLookupWindow (rightly) throw BadWindow. Reviewed-and-Tested-by: Michel Dänzer Signed-off-by: Adam Jackson --- test/xi2/protocol-xiquerypointer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/test/xi2/protocol-xiquerypointer.c b/test/xi2/protocol-xiquerypointer.c index c0421f6dd..2bf18fadc 100644 --- a/test/xi2/protocol-xiquerypointer.c +++ b/test/xi2/protocol-xiquerypointer.c @@ -140,6 +140,7 @@ request_XIQueryPointer(ClientPtr client, xXIQueryPointerReq * req, int error) client_request.swapped = TRUE; swaps(&req->deviceid); + swapl(&req->win); swaps(&req->length); rc = SProcXIQueryPointer(&client_request); assert(rc == error);