andreacavalli/xserver-multidpi
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Always check the return value of __glXGetDrawable first.

Browse Source 
Fixes spurious GLX protocol errors because __glXGetDrawable doesn't set the
error code in case of success. Maybe it should, though.
This commit is contained in:
Michel Dänzer 2007-10-16 12:46:07 +02:00
parent 8b5078b7d9
commit 70a5d33c9e
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
GL/glx/glxcmds.c
View File

@ -1617,7 +1617,7 @@ int __glXDisp_ReleaseTexImageEXT(__GLXclientState *cl, GLbyte *pc)
return error;
pGlxDraw = __glXGetDrawable(NULL, drawId, client, &error);
if (error != Success || pGlxDraw->type != GLX_DRAWABLE_PIXMAP) {
if (!pGlxDraw || pGlxDraw->type != GLX_DRAWABLE_PIXMAP) {
client->errorValue = drawId;
return error;
}
@ -1675,7 +1675,7 @@ int __glXDisp_CopySubBufferMESA(__GLXclientState *cl, GLbyte *pc)
}
pGlxDraw = __glXGetDrawable(glxc, drawId, client, &error);
if (error != Success)
if (!pGlxDraw)
return error;
if (pGlxDraw == NULL ||