andreacavalli/xserver-multidpi
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

glamor: zero num_formats from the start

Browse Source 
The caller may ignore the return value (will be addressed with later
commit) so simply zero the count from the get-go. We're pretty much do
so, in all cases but one :-\

Fixes: cef12efc15 ("glamor: Implement GetSupportedModifiers")
Cc: Louis-Francis Ratté-Boulianne <lfrb@collabora.com>
Cc: Daniel Stone <daniels@collabora.com>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
This commit is contained in:
Emil Velikov 2018-04-02 16:41:23 +01:00 committed by Adam Jackson
parent ac48724639
commit 71a069fd7f
1 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
glamor/glamor_egl.c
View File

@ -596,30 +596,26 @@ glamor_get_formats(ScreenPtr screen,
struct glamor_egl_screen_private *glamor_egl;
EGLint num;
/* Explicitly zero the count as the caller may ignore the return value */
*num_formats = 0;
glamor_egl = glamor_egl_get_screen_private(xf86ScreenToScrn(screen));
if (!glamor_egl->dmabuf_capable)
return FALSE;
if (!eglQueryDmaBufFormatsEXT(glamor_egl->display, 0, NULL, &num)) {
*num_formats = 0;
if (!eglQueryDmaBufFormatsEXT(glamor_egl->display, 0, NULL, &num))
return FALSE;
}
if (num == 0) {
*num_formats = 0;
if (num == 0)
return TRUE;
}
*formats = calloc(num, sizeof(CARD32));
if (*formats == NULL) {
*num_formats = 0;
if (*formats == NULL)
return FALSE;
}
if (!eglQueryDmaBufFormatsEXT(glamor_egl->display, num,
(EGLint *) *formats, &num)) {
*num_formats = 0;
free(*formats);
return FALSE;
}