andreacavalli/xserver-multidpi
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

os: OsSigHandler should not show rtld errors for unrelated signals

Browse Source 
If RTLD_DI_SETSIGNAL is set to let us turn runtime linker/loader errors
into catchable signals, then we should only show the errors when catching
that signal, instead of tossing out red herrings to distract people with
unrelated crashes long after their last failed symbol lookup (especially
when using drivers built to support multiple API's by checking which
symbols are available before calling them).

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Keith Packard <keithp@keithp.com>
Reviewed-by: Aaron Plattner <aplattner@nvidia.com>
This commit is contained in:
Alan Coopersmith 2016-09-10 21:08:01 -07:00 committed by Adam Jackson
parent 065eb66124
commit 75c1d04650
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
os/osinit.c
View File

@ -114,10 +114,14 @@ OsSigHandler(int signo)
#endif
{
#ifdef RTLD_DI_SETSIGNAL
const char *dlerr = dlerror();
# define SIGNAL_FOR_RTLD_ERROR SIGQUIT
if (signo == SIGNAL_FOR_RTLD_ERROR) {
const char *dlerr = dlerror();
if (dlerr) {
LogMessageVerbSigSafe(X_ERROR, 1, "Dynamic loader error: %s\n", dlerr);
if (dlerr) {
LogMessageVerbSigSafe(X_ERROR, 1,
"Dynamic loader error: %s\n", dlerr);
}
}
#endif /* RTLD_DI_SETSIGNAL */
@ -217,7 +221,7 @@ OsInit(void)
* after ourselves.
*/
{
int failure_signal = SIGQUIT;
int failure_signal = SIGNAL_FOR_RTLD_ERROR;
dlinfo(RTLD_SELF, RTLD_DI_SETSIGNAL, &failure_signal);
}