From 7f457351d2a09013cd57fcb2f95c0d6f56bfaccb Mon Sep 17 00:00:00 2001 From: Tiago Vignatti Date: Mon, 19 Apr 2010 20:18:51 +0300 Subject: [PATCH] xfree86: check for NULL pointer before dereferences it in parser code Seems to be harmless. Meh. Signed-off-by: Tiago Vignatti Reviewed-by: Peter Hutterer Reviewed-by: Dan Nicholson --- hw/xfree86/parser/scan.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/parser/scan.c b/hw/xfree86/parser/scan.c index 8aab0cf41..06710d55a 100644 --- a/hw/xfree86/parser/scan.c +++ b/hw/xfree86/parser/scan.c @@ -845,10 +845,13 @@ static int ConfigFilter(const struct dirent *de) { const char *name = de->d_name; - size_t len = strlen(name); + size_t len; size_t suflen = strlen(XCONFIGSUFFIX); - if (!name || name[0] == '.' || len <= suflen) + if (!name || name[0] == '.') + return 0; + len = strlen(name); + if(len <= suflen) return 0; if (strcmp(&name[len-suflen], XCONFIGSUFFIX) != 0) return 0;