andreacavalli/xserver-multidpi
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

xdmauth: Correct miscall of abs() to instrad call labs()

Browse Source 
xdmauth.c:230:13: warning: absolute value function 'abs' given an argument of type 'long' but has parameter of
type
'int'
      which may cause truncation of value [-Wabsolute-value,Semantic Issue]
        if (abs(now - client->time) > TwentyFiveMinutes) {
            ^
xdmauth.c:230:13: note: use function 'labs' instead [Semantic Issue]
        if (abs(now - client->time) > TwentyFiveMinutes) {
            ^~~
            labs
xdmauth.c:302:9: warning: absolute value function 'abs' given an argument of type 'long' but has parameter of type
'int' which
      may cause truncation of value [-Wabsolute-value,Semantic Issue]
    if (abs(client->time - now) > TwentyMinutes) {
        ^
xdmauth.c:302:9: note: use function 'labs' instead [Semantic Issue]
    if (abs(client->time - now) > TwentyMinutes) {
        ^~~
        labs

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
This commit is contained in:
Jeremy Huddleston 2015-10-14 15:13:36 -07:00 committed by Adam Jackson
parent 9f0fcd14b5
commit 85eb90ea45
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
os/xdmauth.c
View File

@ -227,7 +227,7 @@ XdmClientAuthTimeout(long now)
prev = 0; prev = 0;
for (client = xdmClients; client; client = next) { for (client = xdmClients; client; client = next) {
next = client->next; next = client->next;
if (abs(now - client->time) > TwentyFiveMinutes) { if (labs(now - client->time) > TwentyFiveMinutes) {
if (prev) if (prev)
prev->next = next; prev->next = next;
else else
@ -299,7 +299,7 @@ XdmAuthorizationValidate(unsigned char *plain, int length,
} }
now += clockOffset; now += clockOffset;
XdmClientAuthTimeout(now); XdmClientAuthTimeout(now);
if (abs(client->time - now) > TwentyMinutes) { if (labs(client->time - now) > TwentyMinutes) {
free(client); free(client);
if (reason) if (reason)
*reason = "Excessive XDM-AUTHORIZATION-1 time offset"; *reason = "Excessive XDM-AUTHORIZATION-1 time offset";