From 9f21872ad8591c1f6f8ea1e466f212c3582d3c33 Mon Sep 17 00:00:00 2001 From: Adam Jackson Date: Mon, 7 May 2018 17:21:19 -0400 Subject: [PATCH] glx: Be sure to set an error for ghost contexts Otherwise the caller is going to return garbage memory for the error value. Signed-off-by: Adam Jackson --- glx/glxcmds.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/glx/glxcmds.c b/glx/glxcmds.c index 6785e9db3..54d452e58 100644 --- a/glx/glxcmds.c +++ b/glx/glxcmds.c @@ -137,8 +137,10 @@ validGlxContext(ClientPtr client, XID id, int access_mode, __GLXcontext ** context, int *err) { /* no ghost contexts */ - if (id & SERVER_BIT) + if (id & SERVER_BIT) { + *err = __glXError(GLXBadContext); return FALSE; + } *err = dixLookupResourceByType((void **) context, id, __glXContextRes, client, access_mode);