os: Fix warning in LockServer
The meson build gives me: ../os/utils.c: In function ‘LockServer’: ../os/utils.c:310:40: warning: ‘snprintf’ output may be truncated before the last format character [-Wformat-truncation=] snprintf(pid_str, sizeof(pid_str), "%10ld\n", (long) getpid()); ^~~~~~~~~ ../os/utils.c:310:5: note: ‘snprintf’ output between 12 and 13 bytes into a destination of size 12 snprintf(pid_str, sizeof(pid_str), "%10ld\n", (long) getpid()); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Which seems to be due to the %d part meaning that a negative number's - sign would be one wider than we're expecting. Fine, just coerce it to unsigned. Signed-off-by: Adam Jackson <ajax@redhat.com> Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
This commit is contained in:
parent
3bc32a7f59
commit
aabf65d2a0
|
@ -307,7 +307,7 @@ LockServer(void)
|
|||
}
|
||||
if (lfd < 0)
|
||||
FatalError("Could not create lock file in %s\n", tmp);
|
||||
snprintf(pid_str, sizeof(pid_str), "%10ld\n", (long) getpid());
|
||||
snprintf(pid_str, sizeof(pid_str), "%10lu\n", (unsigned long) getpid());
|
||||
if (write(lfd, pid_str, 11) != 11)
|
||||
FatalError("Could not write pid to lock file in %s\n", tmp);
|
||||
(void) fchmod(lfd, 0444);
|
||||
|
|
Loading…
Reference in New Issue
Block a user