From c137f681680e1d04b1513a8be68aeda4d1c56fd5 Mon Sep 17 00:00:00 2001 From: Jeremy Huddleston Date: Sun, 11 Jan 2009 01:42:24 -0800 Subject: [PATCH] XQuartz: misc 1.6 updates (still --disable-glx) rlAccel is not longer compatable, and it's not worth fixing Don't override DeviceCursorInitialize with a noop Don't do a SwitchCoreKeyboard (which wasn't even needed in the first place) --- hw/xquartz/darwin.c | 11 +++++++++++ hw/xquartz/mach-startup/Makefile.am | 1 - hw/xquartz/quartzKeyboard.c | 2 -- hw/xquartz/xpr/xprCursor.c | 27 +++++---------------------- hw/xquartz/xpr/xprScreen.c | 4 +++- 5 files changed, 19 insertions(+), 26 deletions(-) diff --git a/hw/xquartz/darwin.c b/hw/xquartz/darwin.c index 07b243ba4..c104589e6 100644 --- a/hw/xquartz/darwin.c +++ b/hw/xquartz/darwin.c @@ -510,6 +510,17 @@ void InitInput( int argc, char **argv ) darwinTabletEraser->name = strdup("eraser"); darwinTabletCurrent = darwinTabletStylus; + + ActivateDevice(darwinKeyboard); + ActivateDevice(darwinPointer); + ActivateDevice(darwinTabletStylus); + ActivateDevice(darwinTabletCursor); + ActivateDevice(darwinTabletEraser); + EnableDevice(darwinKeyboard); + EnableDevice(darwinPointer); + EnableDevice(darwinTabletStylus); + EnableDevice(darwinTabletCursor); + EnableDevice(darwinTabletEraser); DarwinEQInit(); diff --git a/hw/xquartz/mach-startup/Makefile.am b/hw/xquartz/mach-startup/Makefile.am index bbad10ad1..40060d01b 100644 --- a/hw/xquartz/mach-startup/Makefile.am +++ b/hw/xquartz/mach-startup/Makefile.am @@ -18,7 +18,6 @@ X11_bin_LDADD = \ $(top_builddir)/hw/xquartz/xpr/libXquartzXpr.la \ $(top_builddir)/dix/dixfonts.lo \ $(top_builddir)/miext/rootless/librootless.la \ - $(top_builddir)/miext/rootless/accel/librlAccel.la \ $(top_builddir)/hw/xquartz/pbproxy/libxpbproxy.la \ $(DARWIN_LIBS) $(XSERVER_LIBS) $(XSERVER_SYS_LIBS) -lXplugin diff --git a/hw/xquartz/quartzKeyboard.c b/hw/xquartz/quartzKeyboard.c index 945f01e3d..72f94b443 100644 --- a/hw/xquartz/quartzKeyboard.c +++ b/hw/xquartz/quartzKeyboard.c @@ -362,8 +362,6 @@ void DarwinKeyboardInit(DeviceIntPtr pDev) { XkbSetRepeatKeys(pDev, -1, AutoRepeatModeOn); } - // TODO: What do we do now in 1.6? - SwitchCoreKeyboard(pDev); DarwinKeyboardSetDeviceKeyMap(&keySyms); } diff --git a/hw/xquartz/xpr/xprCursor.c b/hw/xquartz/xpr/xprCursor.c index bf1a6e875..4345beea4 100644 --- a/hw/xquartz/xpr/xprCursor.c +++ b/hw/xquartz/xpr/xprCursor.c @@ -239,7 +239,6 @@ QuartzSetCursor(DeviceIntPtr pDev, ScreenPtr pScreen, CursorPtr pCursor, int x, } } - /* * QuartzMoveCursor * Move the cursor. This is a noop for us. @@ -249,25 +248,6 @@ QuartzMoveCursor(DeviceIntPtr pDev, ScreenPtr pScreen, int x, int y) { } -/* TODO: New for 1.6 ... probably noop */ -static Bool QuartzDeviceCursorInitialize(DeviceIntPtr pDev, ScreenPtr pScreen) { - return TRUE; -} - -/* TODO: New for 1.6 ... probably noop */ -static void QuartzDeviceCursorCleanup(DeviceIntPtr pDev, ScreenPtr pScreen) { -} - -static miPointerSpriteFuncRec quartzSpriteFuncsRec = { - QuartzRealizeCursor, - QuartzUnrealizeCursor, - QuartzSetCursor, - QuartzMoveCursor, - QuartzDeviceCursorInitialize, - QuartzDeviceCursorCleanup -}; - - /* =========================================================================== @@ -387,13 +367,16 @@ QuartzInitCursor(ScreenPtr pScreen) PointPriv = dixLookupPrivate(&pScreen->devPrivates, miPointerScreenKey); ScreenPriv->spriteFuncs = PointPriv->spriteFuncs; - PointPriv->spriteFuncs = &quartzSpriteFuncsRec; + PointPriv->spriteFuncs->RealizeCursor = QuartzRealizeCursor; + PointPriv->spriteFuncs->UnrealizeCursor = QuartzUnrealizeCursor; + PointPriv->spriteFuncs->SetCursor = QuartzSetCursor; + PointPriv->spriteFuncs->MoveCursor = QuartzMoveCursor; + ScreenPriv->cursorVisible = TRUE; return TRUE; } - /* * QuartzSuspendXCursor * X server is hiding. Restore the Aqua cursor. diff --git a/hw/xquartz/xpr/xprScreen.c b/hw/xquartz/xpr/xprScreen.c index 52fb9c986..da262f654 100644 --- a/hw/xquartz/xpr/xprScreen.c +++ b/hw/xquartz/xpr/xprScreen.c @@ -364,7 +364,9 @@ xprSetupScreen(int index, ScreenPtr pScreen) { // Initialize accelerated rootless drawing // Note that this must be done before DamageSetup(). - RootlessAccelInit(pScreen); + + // These are crashing ugly... better to be stable and not crash for now. + //RootlessAccelInit(pScreen); #ifdef DAMAGE // The Damage extension needs to wrap underneath the