andreacavalli/xserver-multidpi
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Initialize the fourcc value in stack-allocated glitz_pixel_format_t

Browse Source 
structures. Greatly reduces the number of uninitialized-value accesses
    during Xgl startup according to valgrind. Allocating and filling these
    in by hand on the stack seems very shady to me.
This commit is contained in:
Eric Anholt 2005-12-31 08:01:31 +00:00
parent e6dab3d7c4
commit c25536a793
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ChangeLog
View File

@ -1,3 +1,11 @@
2005-12-30 Eric Anholt <anholt@FreeBSD.org>
* hw/xgl/xglsync.c: (xglSyncBits), (xglSyncSurface):
Initialize the fourcc value in stack-allocated glitz_pixel_format_t
structures. Greatly reduces the number of uninitialized-value accesses
during Xgl startup according to valgrind. Allocating and filling these
in by hand on the stack seems very shady to me.
2005-12-30 Eric Anholt <anholt@FreeBSD.org>
* configure.ac:

2
hw/xgl/xglsync.c
View File

@ -173,6 +173,7 @@ xglSyncBits (DrawablePtr pDrawable,
pBox = REGION_RECTS (&region);
nBox = REGION_NUM_RECTS (&region);
format.fourcc = GLITZ_FOURCC_RGB;
format.masks = pPixmapPriv->pPixel->masks;
while (nBox--)
@ -250,6 +251,7 @@ xglSyncSurface (DrawablePtr pDrawable)
pBox = REGION_RECTS (pRegion);
pExt = REGION_EXTENTS (pDrawable->pScreen, pRegion);
format.fourcc = GLITZ_FOURCC_RGB;
format.masks = pPixmapPriv->pPixel->masks;
format.xoffset = pExt->x1;