os: "Server terminated successfully" is not an error
ErrorFSigSafe calls LogVMessageVerbSigSafe with the message type set to X_ERROR. That generates this in the log: (EE) Server terminated successfully (0). Closing log file. People periodically report this as an error, sometimes quoting this "error" rather than an earlier error that actually caused a problem. v2: Use X_INFO instead of X_NOTICE Signed-off-by: Aaron Plattner <aplattner@nvidia.com> Reviewed-by: Keith Packard <keithp@keithp.com> Reviewed-by: Eric Anholt <eric@anholt.net> Signed-off-by: Keith Packard <keithp@keithp.com>
This commit is contained in:
parent
b09d593428
commit
c299400168
7
os/log.c
7
os/log.c
|
@ -257,8 +257,11 @@ void
|
||||||
LogClose(enum ExitCode error)
|
LogClose(enum ExitCode error)
|
||||||
{
|
{
|
||||||
if (logFile) {
|
if (logFile) {
|
||||||
ErrorFSigSafe("Server terminated %s (%d). Closing log file.\n",
|
int msgtype = (error == EXIT_NO_ERROR) ? X_INFO : X_ERROR;
|
||||||
(error == EXIT_NO_ERROR) ? "successfully" : "with error", error);
|
LogMessageVerbSigSafe(msgtype, -1,
|
||||||
|
"Server terminated %s (%d). Closing log file.\n",
|
||||||
|
(error == EXIT_NO_ERROR) ? "successfully" : "with error",
|
||||||
|
error);
|
||||||
fclose(logFile);
|
fclose(logFile);
|
||||||
logFile = NULL;
|
logFile = NULL;
|
||||||
logFileFd = -1;
|
logFileFd = -1;
|
||||||
|
|
Loading…
Reference in New Issue
Block a user