andreacavalli/xserver-multidpi
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Track damage for fbTrapezoids() and fbTriangles().

Browse Source 
These calls no longer go through the CompositePicture() hook, so
damage was no longer generated for them. This patch simply damages the
entire destination clip region.

It would be possible to generate tighter damage for certain operators
such as Over and Add, where blank source pixels have no effect on the
destination, but given that virtually all trapezoid rendering takes
place on pixmaps, it's unlikely that anybody would actually benefit
from this optimization, and the miTrapezoidBounds function did
sometimes show up on profiles, probably because it does several
divisions per trapezoid.

V2: Call DamageRegionProcessPending() - pointed out by Michel Dänzer.
V3: Call DamageRegionProcessPending() *after* rendering -
        pointed out by Maarten Maathuis

Reviewed-by: Michel Dänzer <daenzer@vmware.com>
Signed-off-by: Søren Sandmann <ssp@redhat.com>
This commit is contained in:
Søren Sandmann Pedersen 2011-03-28 11:38:11 -04:00
parent 918a9c99cf
commit c7bce22b58
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
fb/fbtrap.c
View File

@ -29,6 +29,7 @@
#include "picturestr.h"
#include "mipict.h"
#include "fbpict.h"
#include "damage.h"
void
fbAddTraps (PicturePtr pPicture,
@ -117,6 +118,8 @@ fbShapes (CompositeShapesFunc composite,
{
pixman_format_code_t format;
DamageRegionAppend (pDst->pDrawable, pDst->pCompositeClip);
if (!maskFormat)
{
int i;
@ -161,6 +164,8 @@ fbShapes (CompositeShapesFunc composite,
yDst + dst_yoff,
nshapes, shapes);
}
DamageRegionProcessPending (pDst->pDrawable);
}
free_pixman_pict (pSrc, src);