dix: Guard against non-existing PtrFeedbackPtr
Trying to change the pointer control settings on a device without PtrFeedbackPtr would be a bug and a crash in the Xserver. Guard against that case by returning early with a BadImplementation error, that might kill the X11 client but the Xserver would survive. Signed-off-by: Olivier Fourdan <ofourdan@redhat.com> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> Related: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1137
This commit is contained in:
parent
ab76272a7d
commit
dee2bb033e
|
@ -2257,6 +2257,9 @@ ProcChangePointerControl(ClientPtr client)
|
|||
REQUEST(xChangePointerControlReq);
|
||||
REQUEST_SIZE_MATCH(xChangePointerControlReq);
|
||||
|
||||
/* If the device has no PtrFeedbackPtr, the xserver has a bug */
|
||||
BUG_RETURN_VAL (!mouse->ptrfeed, BadImplementation);
|
||||
|
||||
ctrl = mouse->ptrfeed->ctrl;
|
||||
if ((stuff->doAccel != xTrue) && (stuff->doAccel != xFalse)) {
|
||||
client->errorValue = stuff->doAccel;
|
||||
|
|
Loading…
Reference in New Issue