Xi: return AlreadyGrabbed for key grabs > 255
We can't have high keycodes because everything in XKB relies on 8 bits. XI2's API allows for 32-bit keycodes so we have to take those but nothing in the server is really ready for this. The effect of this right now is that any high keycode grab is clipped to 255 and thus ends up grabbing a different key instead. https://bugzilla.redhat.com/show_bug.cgi?id=1697804 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
This commit is contained in:
parent
dea4a74621
commit
f4cdbf640b
|
@ -203,8 +203,14 @@ ProcXIPassiveGrabDevice(ClientPtr client)
|
|||
¶m, XI2, &mask);
|
||||
break;
|
||||
case XIGrabtypeKeycode:
|
||||
status = GrabKey(client, dev, mod_dev, stuff->detail,
|
||||
¶m, XI2, &mask);
|
||||
/* XI2 allows 32-bit keycodes but thanks to XKB we can never
|
||||
* implement this. Just return an error for all keycodes that
|
||||
* cannot work anyway */
|
||||
if (stuff->detail > 255)
|
||||
status = XIAlreadyGrabbed;
|
||||
else
|
||||
status = GrabKey(client, dev, mod_dev, stuff->detail,
|
||||
¶m, XI2, &mask);
|
||||
break;
|
||||
case XIGrabtypeEnter:
|
||||
case XIGrabtypeFocusIn:
|
||||
|
|
Loading…
Reference in New Issue