andreacavalli/xserver-multidpi
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

hw/xwin: Warning fix in ProcWindowsWMFrameSetTitle()

Browse Source 
winwindowswm.c: In function ‘ProcWindowsWMFrameSetTitle’:
winwindowswm.c:514: error: pointer targets in passing argument 2 of ‘strncpy’ differ in signedness

If you're going to stick random casts into your code, at least use the goddammed
right ones. :-)

Signed-off-by: Colin Harrison <colin.harrison@virgin.net>
Reviewed-by: Jon TURNEY <jon.turney@dronecode.org.uk>
This commit is contained in:
Colin Harrison 2010-10-19 23:42:53 +01:00 committed by Jon TURNEY
parent 97c9ed026a
commit f7f0739311
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hw/xwin/winwindowswm.c
View File

@ -491,7 +491,7 @@ ProcWindowsWMFrameSetTitle(ClientPtr client)
#endif
title_bytes = malloc(title_length + 1);
strncpy(title_bytes, (unsigned char *) &stuff[1], title_length);
strncpy(title_bytes, (char *) &stuff[1], title_length);
title_bytes[title_length] = '\0';
pRLWinPriv = (win32RootlessWindowPtr) RootlessFrameForWindow(pWin, FALSE);