From f85e4edba489316950fc3422f39e3c2ef8fb1ac5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Spintzyk?= Date: Thu, 22 Jul 2021 13:12:05 +0200 Subject: [PATCH] modesetting: unflip not possible when glamor is not set This is fixing crashes of xfce when running under qemu (cherry picked from commit 8836b9d243444031b6396d39d345f2f83b5fa6a9) --- hw/xfree86/drivers/modesetting/present.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/xfree86/drivers/modesetting/present.c b/hw/xfree86/drivers/modesetting/present.c index 02671c594..186309a29 100644 --- a/hw/xfree86/drivers/modesetting/present.c +++ b/hw/xfree86/drivers/modesetting/present.c @@ -257,6 +257,9 @@ ms_present_check_unflip(RRCrtcPtr crtc, pixmap->devKind != drmmode_bo_get_pitch(&ms->drmmode.front_bo)) return FALSE; + if (!ms->drmmode.glamor) + return FALSE; + #ifdef GBM_BO_WITH_MODIFIERS /* Check if buffer format/modifier is supported by all active CRTCs */ gbm = glamor_gbm_bo_from_pixmap(screen, pixmap);