From 890f536f8d66f08e7d6a5685659eef4001a8757d Mon Sep 17 00:00:00 2001
From: Jamey Sharp <jamey@minilop.net>
Date: Fri, 14 May 2010 00:18:14 -0700
Subject: [PATCH] Bugfix for "Pre-validate ChangeGC XIDs": off-by-one in loop
 index.

Signed-off-by: Jamey Sharp <jamey@minilop.net>
Tested-by: Colin Harrison <colin.harrison@virgin.net>
---
 dix/gc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dix/gc.c b/dix/gc.c
index 00b63bd2d..5a0d00d5a 100644
--- a/dix/gc.c
+++ b/dix/gc.c
@@ -439,7 +439,7 @@ ChangeGCXIDs(ClientPtr client, GC *pGC, BITS32 mask, CARD32 *pC32)
 	client->errorValue = mask;
 	return BadValue;
     }
-    for (i = Ones(mask); i; --i)
+    for (i = Ones(mask); i--; )
 	vals[i].val = pC32[i];
     for (i = 0; i < sizeof(xidfields) / sizeof(*xidfields); ++i)
     {