Jeremy Huddleston Sequoia
9fe7f5ccad
XQuartz: Silence -Wunused-variable
...
X11Controller.m:939:9: warning: unused variable 'remain' [-Wunused-variable,Unused Entity Issue]
int remain;
^
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
2015-06-09 23:42:03 -07:00
Jeremy Huddleston Sequoia
0b9c324891
XQuartz: Silence -Wpointer-bool-conversion
...
X11Controller.m:417:17: error: address of function 'asl_log_descriptor' will always evaluate to 'true'
[-Werror,-Wpointer-bool-conversion,Value Conversion Issue]
if (asl_log_descriptor) {
~~ ^~~~~~~~~~~~~~~~~~
X11Controller.m:417:17: note: prefix with the address-of operator to silence this warning [Semantic Issue]
if (asl_log_descriptor) {
^
&
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
2015-06-09 23:42:02 -07:00
Jeremy Huddleston Sequoia
ec6007e6f7
XQuartz: Ensure we wait for the server thread to terminate
...
AKA: XQuartz 2.7.5 doesn't delete its /tmp/.X$d-lock
http://xquartz.macosforge.org/trac/ticket/823
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
2014-04-06 05:32:03 -07:00
Jeremy Huddleston Sequoia
f79af19417
XQuartz: Mark applicationWillTerminate: noreturn
...
X11Controller.m:938:1: warning: method 'applicationWillTerminate:' could be declared with attribute 'noreturn'
[-Wmissing-noreturn,Semantic Issue]
{
^
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
2014-01-12 23:12:48 -08:00
Jeremy Huddleston Sequoia
d7c9235ee2
XQuartz: Use asl_log_descriptor to log stdout/stderr of child processes
...
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
2013-12-12 01:30:04 -08:00
Jeremy Huddleston Sequoia
f70a8bf371
XQuartz: Don't sleep forever on exit if usleep() returns an error
...
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
2013-11-10 11:40:27 -08:00
Jeremy Huddleston Sequoia
ac616d8ed5
XQuartz: Use asl_log_descriptor for children as well
...
This change is #if'd out due to a bug in asl_log_descriptor, but
it is left here as reference to be enabled in the future.
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
2012-08-16 19:44:00 -07:00
Jeremy Huddleston
5324557c7b
XQuartz: Source formatting cleanup
...
indent butchered Objective-C formatting. This patch was created by:
1) Reverting the indent changes in hw/xquartz
2) Editing X11Application.m and chaning some #ifdef logic to work
with uncrustify
3) Hand edited some (c) notifications
4) Opened all XQuartz sources in XCode and re-indented (^I)
5) Ran uncrustify with this configuration
(as close to the indent rules as I could get):
tok_split_gte=false
utf8_byte=true
utf8_force=true
indent_cmt_with_tabs=false
indent_align_string=false
indent_braces=false
indent_braces_no_func=false
indent_braces_no_class=false
indent_braces_no_struct=false
indent_brace_parent=false
indent_namespace=false
indent_extern=false
indent_class=false
indent_class_colon=false
indent_else_if=false
indent_var_def_cont=false
indent_func_call_param=false
indent_func_def_param=false
indent_func_proto_param=false
indent_func_class_param=false
indent_func_ctor_var_param=false
indent_template_param=false
indent_func_param_double=false
indent_relative_single_line_comments=false
indent_col1_comment=false
indent_access_spec_body=false
indent_paren_nl=false
indent_comma_paren=false
indent_bool_paren=false
indent_first_bool_expr=false
indent_square_nl=false
indent_preserve_sql=false
indent_align_assign=true
sp_balance_nested_parens=false
align_keep_tabs=false
align_with_tabs=false
align_on_tabstop=false
align_number_left=false
align_func_params=false
align_same_func_call_params=false
align_var_def_colon=true
align_var_def_attribute=true
align_var_def_inline=true
align_right_cmt_mix=false
align_on_operator=false
align_mix_var_proto=false
align_single_line_func=false
align_single_line_brace=false
align_nl_cont=false
align_left_shift=true
align_oc_decl_colon=true
nl_collapse_empty_body=true
nl_assign_leave_one_liners=true
nl_class_leave_one_liners=true
nl_enum_leave_one_liners=true
nl_getset_leave_one_liners=true
nl_func_leave_one_liners=true
nl_if_leave_one_liners=true
nl_multi_line_cond=false
nl_multi_line_define=false
nl_before_case=true
nl_after_case=true
nl_after_return=false
nl_after_semicolon=true
nl_after_brace_open=true
nl_after_brace_open_cmt=false
nl_after_vbrace_open=false
nl_after_vbrace_open_empty=false
nl_after_brace_close=false
nl_after_vbrace_close=false
nl_define_macro=false
nl_squeeze_ifdef=false
nl_ds_struct_enum_cmt=false
nl_ds_struct_enum_close_brace=false
nl_create_if_one_liner=false
nl_create_for_one_liner=false
nl_create_while_one_liner=false
ls_for_split_full=false
ls_func_split_full=false
nl_after_multiline_comment=false
eat_blanks_after_open_brace=false
eat_blanks_before_close_brace=false
mod_full_brace_if_chain=false
mod_pawn_semicolon=false
mod_full_paren_if_bool=false
mod_remove_extra_semicolon=false
mod_sort_import=false
mod_sort_using=false
mod_sort_include=false
mod_move_case_break=false
mod_remove_empty_return=false
cmt_indent_multi=true
cmt_c_group=false
cmt_c_nl_start=false
cmt_c_nl_end=false
cmt_cpp_group=false
cmt_cpp_nl_start=false
cmt_cpp_nl_end=false
cmt_cpp_to_c=false
cmt_star_cont=false
cmt_multi_check_last=true
cmt_insert_before_preproc=false
pp_indent_at_level=false
pp_region_indent_code=false
pp_if_indent_code=false
pp_define_at_level=false
indent_columns=4
indent_brace=0
indent_switch_case=0
align_struct_init_span=2
align_pp_define_gap=0
align_pp_define_span=2
align_oc_msg_colon_span=16
nl_end_of_file_min=1
nl_func_var_def_blk=0
code_width=78
nl_max=2
newlines=auto
indent_with_tabs=0
sp_arith=force
sp_assign=force
sp_assign_default=force
sp_before_assign=force
sp_after_assign=force
sp_enum_assign=force
sp_enum_before_assign=force
sp_enum_after_assign=force
sp_pp_stringify=add
sp_bool=force
sp_compare=force
sp_inside_paren=remove
sp_paren_paren=remove
sp_paren_brace=force
sp_before_ptr_star=ignore
sp_before_unnamed_ptr_star=force
sp_before_byref=force
sp_before_unnamed_byref=force
sp_after_byref=remove
sp_after_type=force
sp_before_sparen=force
sp_inside_sparen=remove
sp_inside_sparen_close=remove
sp_after_sparen=force
sp_sparen_brace=force
sp_special_semi=force
sp_before_semi=remove
sp_after_semi=force
sp_after_semi_for=force
sp_after_semi_for_empty=remove
sp_before_square=remove
sp_inside_square=remove
sp_after_comma=force
sp_before_comma=remove
sp_paren_comma=force
sp_before_ellipsis=force
sp_after_class_colon=force
sp_before_class_colon=force
sp_before_case_colon=remove
sp_after_cast=remove
sp_inside_paren_cast=remove
sp_sizeof_paren=remove
sp_inside_braces_enum=force
sp_inside_braces_struct=force
sp_inside_braces=force
sp_inside_braces_empty=remove
sp_func_proto_paren=remove
sp_func_def_paren=remove
sp_inside_fparens=remove
sp_inside_fparen=remove
sp_square_fparen=remove
sp_fparen_brace=force
sp_func_call_paren=remove
sp_func_call_paren_empty=remove
sp_return_paren=force
sp_attribute_paren=remove
sp_defined_paren=remove
sp_macro=force
sp_macro_func=force
sp_else_brace=force
sp_brace_else=force
sp_brace_typedef=force
sp_not=remove
sp_inv=remove
nl_start_of_file=remove
nl_end_of_file=force
nl_assign_square=remove
nl_after_square_assign=remove
nl_fcall_brace=remove
nl_enum_brace=remove
nl_struct_brace=remove
nl_union_brace=remove
nl_if_brace=remove
nl_brace_else=force
nl_elseif_brace=remove
nl_else_brace=remove
nl_else_if=remove
nl_for_brace=remove
nl_do_brace=remove
nl_brace_while=remove
nl_switch_brace=remove
nl_case_colon_brace=force
nl_func_type_name=force
nl_func_type_name_class=force
nl_func_proto_type_name=force
nl_func_paren=remove
nl_func_def_paren=remove
nl_func_decl_start=remove
nl_func_def_start=remove
nl_func_decl_args=remove
nl_func_decl_end=remove
nl_func_def_end=remove
nl_func_decl_end_single=remove
nl_func_def_end_single=remove
nl_func_decl_empty=remove
nl_func_def_empty=remove
nl_fdef_brace=force
nl_return_expr=remove
nl_before_if=ignore
nl_after_if=ignore
nl_before_for=ignore
nl_after_for=ignore
nl_before_while=ignore
nl_after_while=ignore
nl_before_switch=ignore
nl_after_switch=ignore
nl_before_do=ignore
nl_after_do=ignore
pp_space=remove
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
2012-03-24 01:07:06 -07:00
Keith Packard
9838b7032e
Introduce a consistent coding style
...
This is strictly the application of the script 'x-indent-all.sh'
from util/modular. Compared to the patch that Daniel posted in
January, I've added a few indent flags:
-bap
-psl
-T PrivatePtr
-T pmWait
-T _XFUNCPROTOBEGIN
-T _XFUNCPROTOEND
-T _X_EXPORT
The typedefs were needed to make the output of sdksyms.sh match the
previous output, otherwise, the code is formatted badly enough that
sdksyms.sh generates incorrect output.
The generated code was compared with the previous version and found to
be essentially identical -- "assert" line numbers and BUILD_TIME were
the only differences found.
The comparison was done with this script:
dir1=$1
dir2=$2
for dir in $dir1 $dir2; do
(cd $dir && find . -name '*.o' | while read file; do
dir=`dirname $file`
base=`basename $file .o`
dump=$dir/$base.dump
objdump -d $file > $dump
done)
done
find $dir1 -name '*.dump' | while read dump; do
otherdump=`echo $dump | sed "s;$dir1;$dir2;"`
diff -u $dump $otherdump
done
Signed-off-by: Keith Packard <keithp@keithp.com>
Acked-by: Daniel Stone <daniel@fooishbar.org>
Acked-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2012-03-21 13:54:42 -07:00
Jeremy Huddleston
47b457541b
XQuartz: Toggle off fullscreen mode when XQuartz is hidden
...
http://xquartz.macosforge.org/trac/ticket/478
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
2012-01-29 14:27:09 -08:00
Jeremy Huddleston
e36e7ad631
XQuartz: Add GUI controls to toggle scroll_in_device_direction
...
Also cleaned up the wording for fullscreen_menu.
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
2011-07-19 20:01:11 -07:00
Jeremy Huddleston
883039e07b
XQuartz: Just NSBeep() for XBell()
...
The CoreAudio path uses deprecated API and has reported crashes that
aren't worth fixing (4e8bf12b13
fixed
one and introduced another). NSBeep() does the job just fine.
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
2010-12-08 13:57:19 -08:00
Jeremy Huddleston
229323a19b
XQuartz: RandR: Don't change the rootless preference when changing RandR mode
...
Also renames a bunch of other variables for better consistency.
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
2010-09-28 09:50:35 -07:00
Jeremy Huddleston
840d12c7a6
XQuartz: Add a defaults option to toggle Alt / Mode_switch
...
See option_sends_alt in Xquartz(1)
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
Reviewed-by: Kevin Van Vechten <kvv@apple.com>
2010-04-11 16:30:19 -07:00
Jeremy Huddleston
840a68dc5e
XQuartz: Cleanup X11Controller.m compilation warnings.
...
Declare X11Controller as implementing NSTableViewDataSource.
Use selectRowIndexes:byExtendingSelection instead of selectRow:byExtendingSelection
Signed-off-by: Jeremy Huddleston <jeremyhu@freedesktop.org>
2009-11-05 18:34:50 -08:00
Jeremy Huddleston
f3223c71cf
XQuartz: Remove the redundant xquartz_resetenv_display
...
unsetenv(DISPLAY) takes care of this for us anyway
(cherry picked from commit d2263645d8
)
2009-09-29 00:34:41 -07:00
Jeremy Huddleston
67a51cd9ef
XQuartz: Fix a bunch of compilation warnings about style
...
(cherry picked from commit 54000bdcbc
)
2009-09-27 23:31:35 -07:00
Jeremy Huddleston
af76bddd7a
XQuartz: Check NSINTEGER_DEFINED to make sure the NSInteger and NSUInteger types are defined.
...
(cherry picked from commit 36e02a8649
)
2009-08-25 20:17:41 -07:00
Jeremy Huddleston
07c935b72f
XQuartz: Use applewmproto 1.4 updated headers.
...
(cherry picked from commit 203df06c0e
)
2009-08-25 20:16:47 -07:00
Jeremy Huddleston
a85523dc50
XQuartz: Avoid a possible spinlock in applicationWillTerminate
...
(cherry picked from commit f430cda0fd
)
2009-07-28 22:54:11 -07:00
Jeremy Huddleston
fb46474feb
XQuartz: Rever the "Set can_quit to true during a Sparkle-initiated relaunch." change
...
This was in place to work around the issue that was correctly solved with the
previous commit (changing the Windows menu behavior). Reverting this change
no longer causes crashing, so it's safe to show the dialog now.
(cherry picked from commit 023cef31bb
)
2009-07-24 09:42:18 -07:00
Jeremy Huddleston
0d73893a57
XQuartz: Change handling of Windows menu to workaround a bug triggered by mixing Sparkle and X11 windows
...
<rdar://problem/7088335> NSApplication releases the separator in the Windows menu even though it's an IBOutlet
(cherry picked from commit 27ac513526
)
2009-07-24 09:42:00 -07:00
Jeremy Huddleston
171409cecb
XQuartz: Set can_quit to true during a Sparkle-initiated relaunch.
...
(cherry picked from commit b2e9a77111
)
2009-07-24 09:41:46 -07:00
Jeremy Huddleston
7ff84d350b
XQuartz: Added a "Check for X11 Updates..." menu item.
...
(cherry picked from commit 305144bfa4
)
2009-07-24 09:41:32 -07:00
Jeremy Huddleston
34b896e50f
XQuartz: SnowLeopard: Help system book name changed in 10.6
...
(cherry picked from commit b57cb05c69
)
2009-01-25 21:26:04 -08:00
Jeremy Huddleston
8f04a52373
XQuartz: Run applications via '/bin/sh -c ...' to support users who expect shell parsing
...
(cherry picked from commit 67455e716e
)
2008-12-21 21:35:33 -08:00
Jeremy Huddleston
76351d2faf
XQuartz: Avoid using login /bin/sh blech. Just use a bash script to start the app, so it will inherit the right environment
...
(cherry picked from commit f4b7ad9cc6
)
2008-12-10 15:07:52 -08:00
Jeremy Huddleston
a9796c7bc4
XQuarz: Setup our PATH and PWD earlier, so our initial client benefits from it as well...
...
(cherry picked from commit cbae2b4473
)
2008-11-28 13:02:41 -08:00
Jeremy Huddleston
eb474adf98
XQuartz: Simplify the xquartz_resetenv_display path
...
(cherry picked from commit d2e0624dd3
)
2008-11-25 11:53:12 -08:00
Jeremy Huddleston
94df1ab7f0
XQuartz: Force X11Controller to reset a broken DISPLAY envvar.
...
(cherry picked from commit f1a52b5b5a
)
2008-11-25 11:53:06 -08:00
Jeremy Huddleston
b262788401
XQuartz: More Tiger ifdefs
...
(cherry picked from commit 803509072f
)
2008-11-21 10:59:26 -08:00
Jeremy Huddleston
f8af66ddb2
XQuartz: Add option to allow access to the menu in fullscreen mode
...
(cherry picked from commit 637a9f4bd1
)
2008-10-31 20:05:39 -07:00
Jeremy Huddleston
f67cd31d2c
XQuartz: More progress towards fullscreen...
...
(cherry picked from commit 628cae86b4
)
(cherry picked from commit b47b7ab6d6
)
2008-10-21 09:34:17 -07:00
Jeremy Huddleston
d13c3cbd43
XQuartz: Some motion made towards supporting fullscreen.
...
(cherry picked from commit 99be3d68b6
)
2008-10-08 18:45:17 -07:00
Jeremy Huddleston
5446adebfb
XQuartz: Send AppleWMReloadPreferences where appropriate.
...
(cherry picked from commit 490cbe9888
)
2008-10-03 11:12:49 -07:00
Jeremy Huddleston
b666ffd781
XQuartz: "Disable" the text when syncing is disabled.
...
(cherry picked from commit 7713d7ab66
)
2008-09-21 17:40:41 -07:00
Jeremy Huddleston
dba290ec23
XQuartz: Added a preferences UI for pbproxy options.
...
(cherry picked from commit d76cca5e1e
)
2008-09-21 17:40:35 -07:00
Jeremy Huddleston
999f3362d5
XQuartz: Dead code removal
...
(cherry picked from commit 43184cd379
)
2008-09-12 15:26:18 -07:00
Jeremy Huddleston
6548a55ebd
XQuartz: 256 color support
...
(cherry picked from commit 8dd6d5c825
)
2008-09-12 15:26:13 -07:00
Jeremy Huddleston
7f5318131d
XQuartz: Removed "Done" button from Applications Customization. Now properly save on exit.
...
(cherry picked from commit 2f1e163d5d
)
(cherry picked from commit 7542c00b96
)
2008-09-03 09:33:45 -07:00
Jeremy Huddleston
0cd6709db5
XQuartz: Fixed editing of Applications menu
...
(cherry picked from commit da647f1add
)
2008-08-30 16:25:06 -07:00
Jeremy Huddleston
f1f44940f1
XQuartz: Support windowItemModMask=0 or -1 to disable window shortcuts.
...
(cherry picked from commit 81187364e5
)
(cherry picked from commit f2ec79e4a1
)
2008-08-20 10:00:43 -07:00
Jeremy Huddleston
6c5612c2e1
XQuartz: Added window_item_modifiers defaults item (and option to localization) to change the modifier keys used for the windows menu.
...
(cherry picked from commit e4110861d3
)
(cherry picked from commit fcfc05482a
)
2008-08-20 10:00:37 -07:00
Jeremy Huddleston
a338007be6
XQuartz: Adjust the screen origin offset properly for multimonitor setups
...
(cherry picked from commit f2020b9836
)
2008-05-01 18:04:18 -07:00
Jeremy Huddleston
e973430608
XQuartz: More startup / threading house cleaning.
...
(cherry picked from commit 72653c24c0
)
2008-04-28 11:49:19 -07:00
Jeremy Huddleston
ef1c520537
XQuartz: Cleaned up startup and thread creation a tad.
...
(cherry picked from commit c861fe00e1
)
2008-04-26 19:21:05 -07:00
Jeremy Huddleston
a8b8700c73
XQuartz: Fixed cmd-tab to bring all windows forward.
...
(cherry picked from commit e48e2ce931
)
2008-04-21 23:45:00 -07:00
Jeremy Huddleston
590688131d
XQuartz: Fixed quit dialog to be more conforming with HIG.
...
(cherry picked from commit 14c6b837bb
)
2008-04-21 19:08:30 -07:00
Jeremy Huddleston
49f2bb4681
XQuartz: More sanitization of the namespace
...
(cherry picked from commit bc50d41f9d
)
2008-04-18 20:25:38 -07:00
Jeremy Huddleston
5183fea6d3
XQuartz: Handled sanitization of namespace better
...
(cherry picked from commit 8cb23d6721
)
2008-04-18 20:07:55 -07:00