xserver-multidpi/hw/xquartz/GL
George Staplin eb6f884d4f XQuartz: GL: Add a branch for a NULL DrawablePtr.
This may fix a bug where a NULL structure pointer was accessed resulting in:
KERN_PROTECTION_FAILURE at 0x0000000000000004

I studied the structures in use, and I believe it was the pDraw->id that resulted in
this fault in attach().

The layout of the _Drawable structure is 4 chars, and then the id, so the offset
seems correct for such a bug.

Also make it return an error for now, and ErrorF() to help us figure out where it's
going wrong elsewhere to cause a NULL DrawablePtr.

I also made various formatting changes, because the formatting was inconsistent.
Next time I will probably do the formatting in a separate commit, but hindsight is
20/20.

I will apply a fix to the 1.5 branch after this, in a similar manner.
2008-11-22 10:38:06 -07:00
..
capabilities.c XQuartz: GL: Add capability detection for depth buffers, and multisampling. 2008-11-04 12:53:12 -07:00
capabilities.h XQuartz: GL: Add capability detection for depth buffers, and multisampling. 2008-11-04 12:53:12 -07:00
indirect.c XQuartz: GL: Add a branch for a NULL DrawablePtr. 2008-11-22 10:38:06 -07:00
Makefile.am XQuartz: Fixed EXTRA_DIST for new GL files. 2008-10-07 11:39:08 -07:00
visualConfigs.c XQuartz: GL: Handle the alpha differently when the alpha is equal to GLCAPS_COLOR_BUF_INVALID_VALUE. 2008-11-12 17:17:25 -07:00
visualConfigs.h XQuartz: GL: Add the proper license information to the new files, and add more commentary to setVisualConfigs(). 2008-10-07 11:31:48 -06:00