xserver-multidpi/hw
Stephan Schreiber 36c18bb81b int10: fix pci_device_read_rom usage
I noticed that the build-in int10 driver always reports
"Unable to retrieve all of segment 0x0C0000."
even though the entire BIOS data is retrieved with success.

The associated code is in hw/xfree86/int10/generic.c, in the function
xf86ExtendedInitInt10():

    if (pci_device_read_rom(pInt->dev, vbiosMem) < V_BIOS_SIZE) {
        xf86DrvMsg(screen, X_WARNING,
                   "Unable to retrieve all of segment 0x0C0000.\n");
    }

The function pci_device_read_rom() is from libpciaccess; its return
value is not a size but an error status code: 0 means success.
If pci_device_read_rom() returns 0 for success, the warning is generated.

The proposed patch corrects the evaluation of the return value of
pci_device_read_rom() and of the supplied BIOS size.

Debian bug#686153

Signed-off-by: Julien Cristau <jcristau@debian.org>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Signed-off-by: Keith Packard <keithp@keithp.com>
2012-10-04 13:06:02 -07:00
..
dmx dix: Remove refs to mi backing store from docs 2012-09-23 10:31:39 -07:00
kdrive Merge remote-tracking branch 'daniels/master' 2012-10-04 11:39:46 -07:00
vfb dix: Remove #includes of mibstore.h 2012-09-23 10:31:27 -07:00
xfree86 int10: fix pci_device_read_rom usage 2012-10-04 13:06:02 -07:00
xnest dix: Remove #includes of mibstore.h 2012-09-23 10:31:27 -07:00
xquartz Merge remote-tracking branch 'ajax/server-1.14-abi-churn' 2012-09-24 11:43:01 -07:00
xwin Merge remote-tracking branch 'ajax/server-1.14-abi-churn' 2012-09-24 11:43:01 -07:00
Makefile.am Catch errors in recursive relink targets 2010-03-22 00:45:57 -05:00