andreacavalli/xserver-multidpi
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
3ead1d810b
xserver-multidpi/test
History
Servaas Vandenberghe 820d9040f5 xfree86: fix potential buffer overflow 
The patch below fixes a potential buffer overflow in xf86addComment().
This occurs if  curlen > 0 && eol_seen == 0 && iscomment == 0 , as
follows from the code:

char *xf86addComment(char *cur, char *add)

<...>

        len = strlen(add);
        endnewline = add[len - 1] == '\n';
        len +=  1 + iscomment + (!hasnewline) + (!endnewline) + eol_seen;

        if ((str = realloc(cur, len + curlen)) == NULL)
                return cur;

        cur = str;

        if (eol_seen || (curlen && !hasnewline))
                cur[curlen++] = '\n';
        if (!iscomment)
                cur[curlen++] = '#';
        strcpy(cur + curlen, add);
        if (!endnewline)
                strcat(cur, "\n");

Signed-off-by: Servaas Vandenberghe <vdb@picaros.org>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>

[whot: added buffer overflow test case]

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2011-10-31 09:39:04 +10:00
..
xi2 test: fix two more failing FP3232 tests 2011-10-27 08:41:08 +10:00
.gitignore Don't use empty source files 2011-06-23 05:28:31 -07:00
fixes.c fixes: Add support for pointer barriers 2011-05-31 15:10:51 -04:00
input.c test: Add unit test for mieq 2011-10-21 00:32:04 -07:00
list.c Add null-terminated list interface. 2011-08-22 15:56:53 +10:00
Makefile.am test: add a option duplication test 2011-08-22 15:56:48 +10:00
misc.c include: add version_compare helper function 2011-05-13 09:41:50 +10:00
README Add a test-suite for in-server unit-testing. 2009-04-28 16:03:56 +10:00
xfree86.c xfree86: fix potential buffer overflow 2011-10-31 09:39:04 +10:00
xkb.c test: remove glib dependency 2011-04-21 13:43:43 +10:00
xtest.c test: remove glib dependency 2011-04-21 13:43:43 +10:00

README 

                        X server test suite

This suite contains a set of tests to verify the behaviour of functions used
internally to the server. This test suite is based on glib's testing
framework [1].

= How it works =
Through some automake abuse, we link the test programs with the same static
libraries as the Xorg binary. The test suites can then call various functions
and verify their behaviour - without the need to start the server or connect
clients.

This testing only works for functions that do not rely on a particular state
of the X server. Unless the test suite replicates the expected state, which
may be difficult.

= How to run the tests =
Run "make check" the test directory. This will compile the tests and execute
them in the order specified in the TESTS variable in test/Makefile.am.

Each set of tests related to a subsystem are available as a binary that can be
executed directly. For example, run "xkb" to perform some xkb-related tests.

== Adding a new test ==
When adding a new test, ensure that you add a short description of what the
test does and what the expected outcome is. If the test reproduces a
particular bug, using g_test_bug().

== Misc ==

The programs "gtester" and "gtester-report" may be used to generate XML/HTML
log files of tests succeeded and failed.

---------

[1] http://library.gnome.org/devel/glib/stable/glib-Testing.html