andreacavalli/xserver-multidpi
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
4b9600a416
xserver-multidpi/Xext
History
Jamey Sharp 4b9600a416 Make WriteEventsToClient/WriteToClient no-op on fake or dead clients. 
This matches the test in TryClientEvents, and is a superset of tests
done by the callers of these functions. The consequence of forgetting
these tests is a server crash, so they're always desirable. In my
opinion, it's better to not require the callers to remember to do these
checks.

For callers that don't do very much work before calling WriteToClient or
WriteEventsToClient, I've removed the redundant checks.

hw/xquartz/xpr/appledri.c has an interesting case: While its check for
"client == NULL" appears redundant with the test in WriteEventsToClient,
it dereferences client to get the sequence number.

Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=27497
Signed-off-by: Jamey Sharp <jamey@minilop.net>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Julien Cristau <jcristau@debian.org>
Reviewed-by: Adam Jackson <ajax@redhat.com>
2010-05-19 12:32:34 -07:00
..
bigreq.c Eliminate boilerplate around client->noClientException. 2010-05-13 17:14:07 -07:00
dpms.c Eliminate boilerplate around client->noClientException. 2010-05-13 17:14:07 -07:00
dpmsproc.h DPMS: Remove unused DPMSGet() 2009-04-03 18:22:20 -04:00
dpmsstubs.c DPMS: Remove unused DPMSGet() 2009-04-03 18:22:20 -04:00
geext.c Eliminate boilerplate around client->noClientException. 2010-05-13 17:14:07 -07:00
geext.h Xext: remove ev_fill from GEExtensions. 2009-03-20 15:17:54 +10:00
geint.h XGE: don't register an extension event 2010-04-13 09:27:32 -07:00
Makefile.am Death to Multibuffer extension 2010-04-21 18:06:35 +03:00
panoramiX.c Eliminate boilerplate around client->noClientException. 2010-05-13 17:14:07 -07:00
panoramiX.h Kill unused/useless macros in panoramiX.h: BREAK_IF, IF_RETURN, FORCE_ROOT 2010-04-26 19:19:02 -07:00
panoramiXh.h Centralize declaration of ConnectionInfo. 2008-08-20 13:14:34 -04:00
panoramiXprocs.c Eliminate boilerplate around client->noClientException. 2010-05-13 17:14:07 -07:00
panoramiXsrv.h Rework symbol visibility for easier maintenance 2008-12-03 05:43:34 -02:00
panoramiXSwap.c Merge branch 'master' into mpx 2008-01-03 17:04:54 +10:30
saver.c Make WriteEventsToClient/WriteToClient no-op on fake or dead clients. 2010-05-19 12:32:34 -07:00
security.c Make WriteEventsToClient/WriteToClient no-op on fake or dead clients. 2010-05-19 12:32:34 -07:00
securitysrv.h Xext: include security protocol header instead of client header 2009-09-20 19:57:01 +10:00
shape.c Make WriteEventsToClient/WriteToClient no-op on fake or dead clients. 2010-05-19 12:32:34 -07:00
shm.c Eliminate boilerplate around client->noClientException. 2010-05-13 17:14:07 -07:00
shmint.h Update to xextproto 7.0.99.1. 2009-07-15 17:00:05 +10:00
sleepuntil.c Replace X-allocation functions with their C89 counterparts 2010-05-13 00:22:37 +07:00
sleepuntil.h Remove RCS tags. Fix Xprint makefile braindamage. 2006-07-21 17:56:00 -04:00
sync.c Make WriteEventsToClient/WriteToClient no-op on fake or dead clients. 2010-05-19 12:32:34 -07:00
syncsrv.h Xext: silence 'warning: no previous prototype' for sync, bigreq and xcmisc. 2009-09-21 09:17:56 +10:00
xace.c Replace X-allocation functions with their C89 counterparts 2010-05-13 00:22:37 +07:00
xace.h Correct outdated e-mail address in "Author" statements. 2009-09-02 17:56:52 -04:00
xacestr.h Correct outdated e-mail address in "Author" statements. 2009-09-02 17:56:52 -04:00
xcalibrate.c Make WriteEventsToClient/WriteToClient no-op on fake or dead clients. 2010-05-19 12:32:34 -07:00
xcmisc.c Eliminate boilerplate around client->noClientException. 2010-05-13 17:14:07 -07:00
xf86bigfont.c Eliminate boilerplate around client->noClientException. 2010-05-13 17:14:07 -07:00
xf86bigfontsrv.h New header for XF86Bigfont server functions 2010-03-22 00:48:04 -05:00
xres.c Eliminate boilerplate around client->noClientException. 2010-05-13 17:14:07 -07:00
xselinux_ext.c Eliminate boilerplate around client->noClientException. 2010-05-13 17:14:07 -07:00
xselinux_hooks.c xselinux: Remove use of devPrivates init/free callbacks. 2010-05-13 10:07:31 -07:00
xselinux_label.c Replace X-allocation functions with their C89 counterparts 2010-05-13 00:22:37 +07:00
xselinux.h xselinux: Bump extension minor version. 2010-02-22 17:05:01 -05:00
xselinuxint.h xselinux: Remove use of devPrivates init/free callbacks. 2010-05-13 10:07:31 -07:00
xtest.c Eliminate boilerplate around client->noClientException. 2010-05-13 17:14:07 -07:00
xvdisp.c Eliminate boilerplate around client->noClientException. 2010-05-13 17:14:07 -07:00
xvdisp.h Fix swapped Xv dispatch under Xinerama. 2007-12-02 14:15:36 -05:00
xvdix.h Fix most remaining deprecated resource lookups. 2009-04-29 01:04:37 -04:00
xvmain.c xv: TryClientEvents already checks client and sets sequenceNumber. 2010-05-19 12:32:34 -07:00
xvmc.c Replace X-allocation functions with their C89 counterparts 2010-05-13 00:22:37 +07:00
xvmcext.h Use libtool convenience libraries and better "symbol" table. 2008-12-07 02:22:19 -02:00