andreacavalli/xserver-multidpi
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
4b9600a416
xserver-multidpi/dix
History
Jamey Sharp 4b9600a416 Make WriteEventsToClient/WriteToClient no-op on fake or dead clients. 
This matches the test in TryClientEvents, and is a superset of tests
done by the callers of these functions. The consequence of forgetting
these tests is a server crash, so they're always desirable. In my
opinion, it's better to not require the callers to remember to do these
checks.

For callers that don't do very much work before calling WriteToClient or
WriteEventsToClient, I've removed the redundant checks.

hw/xquartz/xpr/appledri.c has an interesting case: While its check for
"client == NULL" appears redundant with the test in WriteEventsToClient,
it dereferences client to get the sequence number.

Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=27497
Signed-off-by: Jamey Sharp <jamey@minilop.net>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Julien Cristau <jcristau@debian.org>
Reviewed-by: Adam Jackson <ajax@redhat.com>
2010-05-19 12:32:34 -07:00
..
.gitignore .gitignore: use common defaults with custom section #24239 2009-11-11 21:40:20 -08:00
atom.c Misc coding style cleanup 2010-05-13 06:16:48 +07:00
buildatoms XFree86 4.3.0.1 2003-11-14 16:49:22 +00:00
BuiltInAtoms R6.6 is the Xorg base-line 2003-11-14 15:54:54 +00:00
colormap.c Fix build without XACE 2010-05-17 13:03:12 -07:00
cursor.c Replace X-allocation functions with their C89 counterparts 2010-05-13 00:22:37 +07:00
deprecated.c dix: remove dixLookupResource - we don't have any users left. 2009-09-07 10:51:16 +10:00
devices.c Eliminate boilerplate around client->noClientException. 2010-05-13 17:14:07 -07:00
dispatch.c Eliminate boilerplate around client->noClientException. 2010-05-13 17:14:07 -07:00
dispatch.h Remove RCS tags. Fix Xprint makefile braindamage. 2006-07-21 17:56:00 -04:00
dixfonts.c Replace dixChangeGC with calls directly to the right variant. 2010-05-13 17:14:07 -07:00
dixutils.c Replace X-allocation functions with their C89 counterparts 2010-05-13 00:22:37 +07:00
enterleave.c dix: call SetFocusOut and LeaveWindow when disabling a device. 2009-08-03 10:11:48 +10:00
enterleave.h dix: call SetFocusOut and LeaveWindow when disabling a device. 2009-08-03 10:11:48 +10:00
eventconvert.c Replace X-allocation functions with their C89 counterparts 2010-05-13 00:22:37 +07:00
events.c Make WriteEventsToClient/WriteToClient no-op on fake or dead clients. 2010-05-19 12:32:34 -07:00
extension.c Eliminate boilerplate around client->noClientException. 2010-05-13 17:14:07 -07:00
ffs.c Rework symbol visibility for easier maintenance 2008-12-03 05:43:34 -02:00
gc.c Fix build without XACE 2010-05-17 13:03:12 -07:00
getevents.c Replace X-allocation functions with their C89 counterparts 2010-05-13 00:22:37 +07:00
globals.c DPMS: Remove the defaultDPMS* variables 2009-04-03 18:22:20 -04:00
glyphcurs.c Replace dixChangeGC with calls directly to the right variant. 2010-05-13 17:14:07 -07:00
grabs.c Replace X-allocation functions with their C89 counterparts 2010-05-13 00:22:37 +07:00
initatoms.c Rework symbol visibility for easier maintenance 2008-12-03 05:43:34 -02:00
inpututils.c Replace X-allocation functions with their C89 counterparts 2010-05-13 00:22:37 +07:00
main.c Replace X-allocation functions with their C89 counterparts 2010-05-13 00:22:37 +07:00
Makefile.am dtrace: Add Xserver-dtrace.h to CLEANFILES 2009-12-15 16:51:48 -08:00
pixmap.c Replace X-allocation functions with their C89 counterparts 2010-05-13 00:22:37 +07:00
privates.c Remove devPrivates init and delete callback lists. 2010-05-13 14:16:32 -07:00
property.c Eliminate boilerplate around client->noClientException. 2010-05-13 17:14:07 -07:00
protocol.txt Add DRI2 requests to protocol.txt 2009-08-28 23:29:05 -04:00
ptrveloc.c Replace X-allocation functions with their C89 counterparts 2010-05-13 00:22:37 +07:00
registry.c Replace X-allocation functions with their C89 counterparts 2010-05-13 00:22:37 +07:00
resource.c Replace X-allocation functions with their C89 counterparts 2010-05-13 00:22:37 +07:00
selection.c Eliminate boilerplate around client->noClientException. 2010-05-13 17:14:07 -07:00
swaprep.c Replace X-allocation functions with their C89 counterparts 2010-05-13 00:22:37 +07:00
swapreq.c Remove #define NEED_EVENTS and NEED_REPLIES 2008-12-12 11:43:32 +10:00
tables.c Remove #define NEED_EVENTS and NEED_REPLIES 2008-12-12 11:43:32 +10:00
window.c Quit using clientErrorValue in dix/colormap.c. 2010-05-13 17:14:07 -07:00
Xserver-dtrace.h.in Update Sun license notices to current X.Org standard form 2009-12-16 17:11:35 -08:00
Xserver.d Update Sun license notices to current X.Org standard form 2009-12-16 17:11:35 -08:00